Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmodulemd: 2.12.0 -> 2.12.1 #121659

Merged
merged 1 commit into from May 8, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 4, 2021

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/fedora-modularity/libmodulemd/releases.

meta.description for libmodulemd is: "C Library for manipulating module metadata files"

meta.homepage for libmodulemd is: "https://github.com/fedora-modularity/libmodulemd"

meta.changelog for libmodulemd is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/sb93cs5cdmzxnfr3fx8fk3zrss3jqq1a-libmodulemd-2.12.1-bin/bin/modulemd-validator passed the binary check.

  • 1 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 2.12.1 with grep in /nix/store/sb93cs5cdmzxnfr3fx8fk3zrss3jqq1a-libmodulemd-2.12.1-bin

  • found 2.12.1 in filename of file in /nix/store/sb93cs5cdmzxnfr3fx8fk3zrss3jqq1a-libmodulemd-2.12.1-bin

  • directory tree listing: https://gist.github.com/30686a90f1f99dd23be63f539ed48fd1

  • du listing: https://gist.github.com/ffcd8b5c81eb989fb1b710641f2294b2


Rebuild report (if merged into master) (click to expand)
23 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
libdnf
libmodulemd
microdnf
python38Packages.libmodulemd
python39Packages.libmodulemd
rpm-ostree
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/sb93cs5cdmzxnfr3fx8fk3zrss3jqq1a-libmodulemd-2.12.1-bin \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libmodulemd https://github.com/r-ryantm/nixpkgs/archive/aea743915969c4e81d6acb4c3e49b93c1c8c043d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/sb93cs5cdmzxnfr3fx8fk3zrss3jqq1a-libmodulemd-2.12.1-bin
ls -la /nix/store/sb93cs5cdmzxnfr3fx8fk3zrss3jqq1a-libmodulemd-2.12.1-bin/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

6 packages built:
  • libdnf
  • libmodulemd
  • microdnf
  • python38Packages.libmodulemd
  • python39Packages.libmodulemd
  • rpm-ostree

Maintainer pings

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 4, 2021

Result of nixpkgs-review pr 121659 at aea7439 run on x86_64-linux 1

1 package skipped due to time constraints:
  • libmodulemd
5 packages built successfully:
  • libdnf
  • microdnf
  • python38Packages.libmodulemd
  • python39Packages.libmodulemd
  • rpm-ostree
2 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/libmodulemd/default.nix:73:5:

       |
    73 |     maintainers = with maintainers; [ ];
       |     ^
    
  • warning: build-tools-in-build-inputs

    rpm is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/libmodulemd/default.nix:51:3:

       |
    51 |   buildInputs = [
       |   ^
    

Result of nixpkgs-review pr 121659 at aea7439 run on aarch64-linux 1

1 package skipped due to time constraints:
  • libmodulemd
5 packages built successfully:
  • libdnf
  • microdnf
  • python38Packages.libmodulemd
  • python39Packages.libmodulemd
  • rpm-ostree

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 121659 run on x86_64-linux 1

6 packages built:
  • libdnf
  • libmodulemd
  • microdnf
  • python38Packages.libmodulemd
  • python39Packages.libmodulemd
  • rpm-ostree

@jonringer jonringer merged commit aff091d into NixOS:master May 8, 2021
@r-ryantm r-ryantm deleted the auto-update/libmodulemd branch May 9, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants