Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peek: use ffmpeg 4 #121812

Merged
merged 1 commit into from May 10, 2021
Merged

peek: use ffmpeg 4 #121812

merged 1 commit into from May 10, 2021

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented May 5, 2021

Motivation for this change

See migrate away from ffmpeg_3 #120705.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • peek

@ofborg ofborg bot requested review from worldofpeace and puffnfresh May 5, 2021 15:55
jonringer
jonringer approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@puffnfresh do you mind testing it?

@dotlambda dotlambda mentioned this pull request May 6, 2021
Closed
@jonringer
Copy link
Contributor

do you resovling conflicts? looks like a maintainer was removed

@LeSuisse
peek: use ffmpeg 4
2fcba3a 
See migrate away from ffmpeg_3 NixOS#120705.
@ofborg ofborg bot removed the request for review from worldofpeace May 9, 2021 21:04
@SuperSandro2000 SuperSandro2000 merged commit 5e40550 into NixOS:master May 10, 2021
@LeSuisse LeSuisse deleted the peek-ffmpeg4 branch May 10, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @jonringer @SuperSandro2000