Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

petrinizer: fix build #121830

Merged
merged 1 commit into from May 6, 2021
Merged

petrinizer: fix build #121830

merged 1 commit into from May 6, 2021

Conversation

sternenseemann
Copy link
Member

  • take z3 haskell package from haskellPackages
  • take sbv 7.13 from haskellPackages, apply patch fixing build
    with GHC >= 8.8.8
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess it would be nice if we could move pkgs/applications/science/logic/petrinizer/default.nix to one of our non-hackage-packages in pkgs/development/haskell-modules/non-hackage-packages.nix, but that's probably too much work for this PR.

@GrahamcOfBorg build petrinizer

@sternenseemann
Copy link
Member Author

I guess it would be nice if we could move pkgs/applications/science/logic/petrinizer/default.nix to one of our non-hackage-packages in pkgs/development/haskell-modules/non-hackage-packages.nix, but that's probably too much work for this PR.

I'm not sure if we really want that, but given that the packages outside of pkgs/development/haskell-modules are not really maintained for the most part we may want to do that at some point.

Nevertheless, I'd like to do that in a PR which does all of those cleanups at once.

7c6f434c
7c6f434c approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks

@sternenseemann
petrinizer: fix build
2042d3b 
* take z3 haskell package from haskellPackages
* take sbv 7.13 from haskellPackages, apply patch fixing build
  with GHC >= 8.8.8
@sternenseemann sternenseemann merged commit 73c2dd4 into NixOS:haskell-updates May 6, 2021
@sternenseemann sternenseemann deleted the petrinizer-fix-build branch May 6, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @cdepillabout @7c6f434c