Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu_full: add glusterfs support #121832

Merged
merged 1 commit into from May 5, 2021
Merged

qemu_full: add glusterfs support #121832

merged 1 commit into from May 5, 2021

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented May 5, 2021

Motivation for this change

I want to try using the glusterfs native storage backend.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 5, 2021

Result of nixpkgs-review pr 121832 at ddcd4dd run on x86_64-linux 1

1 package built successfully:
  • qemu_full
1 suggestion:
  • warning: build-tools-in-build-inputs

    makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/qemu/default.nix:57:3:

       |
    57 |   buildInputs =
       |   ^
    

Result of nixpkgs-review pr 121832 at ddcd4dd run on aarch64-linux 1

1 package built successfully:
  • qemu_full

@globin globin merged commit 15182d1 into NixOS:master May 5, 2021
@ryantm ryantm deleted the gluster-qemu branch May 5, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants