Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkadot: 0.8.30 -> 0.9.0 #121850

Merged
merged 2 commits into from May 6, 2021
Merged

polkadot: 0.8.30 -> 0.9.0 #121850

merged 2 commits into from May 6, 2021

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented May 5, 2021 •
edited

Motivation for this change

Update to latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric asymmetric requested review from andresilva and akru May 5, 2021 21:44
FlorianFranzen
FlorianFranzen approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@FlorianFranzen FlorianFranzen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it, looks good. My build just finish successfully.

As a side note, you can convert hashes to base32 using nix hash, but I just had a look and could not find anything on the default hash format to use in nixpkgs, so I guess it does not matter.

Feel free to add me as a maintainer, otherwise I will do that in a separate commit.

@ofborg ofborg bot requested review from andresilva and FlorianFranzen May 5, 2021 22:01
FlorianFranzen
FlorianFranzen reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@FlorianFranzen FlorianFranzen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine. LGTM! (submitted another review, because ofborg reset @andresilva and my review status.)

@asymmetric asymmetric mentioned this pull request May 6, 2021
Closed
10 tasks
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 121850 run on x86_64-linux 1

1 package built:
  • polkadot

@RaghavSood RaghavSood merged commit 9332725 into NixOS:master May 6, 2021
@asymmetric asymmetric deleted the polkadot/0.9.0 branch May 6, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen FlorianFranzen approved these changes

@andresilva andresilva andresilva approved these changes

@RaghavSood RaghavSood RaghavSood approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@akru akru Awaiting requested review from akru

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asymmetric @RaghavSood @andresilva @FlorianFranzen