Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certbot: 1.14.0 -> 1.15.0 #121872

Merged
merged 1 commit into from May 8, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 6, 2021

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/certbot/certbot/releases.

meta.description for certbot is: "ACME client that can obtain certs and extensibly update server configurations"

meta.homepage for certbot is: "https://github.com/certbot/certbot"

meta.changelog for certbot is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0/bin/certbot passed the binary check.

  • /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0/bin/.certbot-wrapped passed the binary check.

  • 2 of 2 passed binary check by having a zero exit code.

  • 2 of 2 passed binary check by having the new version present in output.

  • found 1.15.0 with grep in /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0

  • found 1.15.0 in filename of file in /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0

  • directory tree listing: https://gist.github.com/657cc0cd8606039c9b1770c36b445318

  • du listing: https://gist.github.com/5895ddaa0d4b1437b9188d44d14a774f


Rebuild report (if merged into master) (click to expand)
59 total rebuild path(s)

16 package rebuild(s)

16 x86_64-linux rebuild(s)
15 i686-linux rebuild(s)
13 x86_64-darwin rebuild(s)
15 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
certbot
certbot-full
home-assistant
python38Packages.acme
python38Packages.certbot
python38Packages.certbot-dns-cloudflare
python38Packages.certbot-dns-rfc2136
python38Packages.certbot-dns-route53
python38Packages.hass-nabucasa
python39Packages.acme
python39Packages.certbot
python39Packages.certbot-dns-cloudflare
python39Packages.certbot-dns-rfc2136
python39Packages.certbot-dns-route53
python39Packages.hass-nabucasa
simp_le
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A certbot https://github.com/r-ryantm/nixpkgs/archive/5ace3b93224905617e9f0b316a54851f5fc0c5d2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0
ls -la /nix/store/ld17r3n646fad4xwv6xa7ymcsnyp92yk-python3.8-certbot-1.15.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 45m and timed out


Maintainer pings

cc @domenkozar for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 6, 2021

Result of nixpkgs-review pr 121872 at 5ace3b9 run on aarch64-linux 1

1 package failed to build:
  • home-assistant
13 packages built successfully:
  • certbot (python38Packages.certbot)
  • python38Packages.acme
  • python38Packages.certbot-dns-cloudflare
  • python38Packages.certbot-dns-rfc2136
  • python38Packages.certbot-dns-route53
  • python38Packages.hass-nabucasa
  • python39Packages.acme
  • python39Packages.certbot
  • python39Packages.certbot-dns-cloudflare
  • python39Packages.certbot-dns-rfc2136
  • python39Packages.certbot-dns-route53
  • python39Packages.hass-nabucasa
  • simp_le

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 121872 at 5ace3b9 run on x86_64-linux 1

1 package failed to build:
  • home-assistant
14 packages built successfully:
  • certbot (python38Packages.certbot)
  • certbot-full
  • python38Packages.acme
  • python38Packages.certbot-dns-cloudflare
  • python38Packages.certbot-dns-rfc2136
  • python38Packages.certbot-dns-route53
  • python38Packages.hass-nabucasa
  • python39Packages.acme
  • python39Packages.certbot
  • python39Packages.certbot-dns-cloudflare
  • python39Packages.certbot-dns-rfc2136
  • python39Packages.certbot-dns-route53
  • python39Packages.hass-nabucasa
  • simp_le

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 121872 run on x86_64-linux 1

15 packages built:
  • certbot (python38Packages.certbot)
  • certbot-full
  • home-assistant
  • python38Packages.acme
  • python38Packages.certbot-dns-cloudflare
  • python38Packages.certbot-dns-rfc2136
  • python38Packages.certbot-dns-route53
  • python38Packages.hass-nabucasa
  • python39Packages.acme
  • python39Packages.certbot
  • python39Packages.certbot-dns-cloudflare
  • python39Packages.certbot-dns-rfc2136
  • python39Packages.certbot-dns-route53
  • python39Packages.hass-nabucasa
  • simp_le

@jonringer jonringer merged commit d32199f into NixOS:master May 8, 2021
@r-ryantm r-ryantm deleted the auto-update/certbot branch May 9, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants