Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radarr: 3.0.2.4552 -> 3.1.1.4954 #121912

Merged
merged 1 commit into from May 9, 2021
Merged

radarr: 3.0.2.4552 -> 3.1.1.4954 #121912

merged 1 commit into from May 9, 2021

Conversation

NULLx76
Copy link
Member

@NULLx76 NULLx76 commented May 6, 2021

Motivation for this change

https://github.com/Radarr/Radarr/releases/tag/v3.1.1.4954

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edwtjo and purcell May 6, 2021 12:28
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 6, 2021 •
edited

Result of nixpkgs-review pr 121912 at 1c213c0 run on x86_64-linux 1

1 package built successfully:
  • radarr
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/radarr/default.nix:28:3:

       |
28 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 121912 at 1c213c0 run on aarch64-linux 1

1 package built successfully:
  • radarr
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/radarr/default.nix:28:3:

       |
28 |   installPhase = ''
   |   ^

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/374

@SuperSandro2000 SuperSandro2000 merged commit 6140a94 into NixOS:master May 9, 2021
@NULLx76 NULLx76 deleted the radarr-3.1.1.4954 branch May 9, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purcell purcell purcell approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NULLx76 @r-rmcgibbo @nixos-discourse @purcell @SuperSandro2000 @Janik-Haag