Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce.xfce4-panel: 4.16.2 -> 4.16.3 #121918

Merged
merged 1 commit into from May 6, 2021
Merged

xfce.xfce4-panel: 4.16.2 -> 4.16.3 #121918

merged 1 commit into from May 6, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 6, 2021

Motivation for this change

Update to version 4.16.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 6, 2021

Result of nixpkgs-review pr 121918 at 95b47511 run on aarch64-linux 1

7 packages marked as broken and skipped:
  • xfce.xfce4-dockbarx-plugin
  • xfce.xfce4-embed-plugin
  • xfce.xfce4-hardware-monitor-plugin
  • xfce.xfce4_dockbarx_plugin
  • xfce.xfce4_embed_plugin
  • xfce.xfce4_hardware_monitor_plugin
  • xmonad_log_applet_xfce
28 packages built successfully:
  • xfce.orage
  • xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
  • xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
  • xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
  • xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
  • xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
  • xfce.xfce4-dict
  • xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
  • xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
  • xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
  • xfce.xfce4-i3-workspaces-plugin
  • xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
  • xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
  • xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
  • xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
  • xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
  • xfce.xfce4notifyd (xfce.xfce4-notifyd)
  • xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
  • xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
  • xfce.xfce4-screenshooter
  • xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
  • xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
  • xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
  • xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
  • xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
  • xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
  • xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
  • xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)

Result of nixpkgs-review pr 121918 at 95b47511 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • xfce.xfce4-dockbarx-plugin
  • xfce.xfce4-embed-plugin
  • xfce.xfce4-hardware-monitor-plugin
  • xfce.xfce4_dockbarx_plugin
  • xfce.xfce4_embed_plugin
  • xfce.xfce4_hardware_monitor_plugin
  • xmonad_log_applet_xfce
28 packages built successfully:
  • xfce.orage
  • xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
  • xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
  • xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
  • xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
  • xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
  • xfce.xfce4-dict
  • xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
  • xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
  • xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
  • xfce.xfce4-i3-workspaces-plugin
  • xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
  • xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
  • xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
  • xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
  • xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
  • xfce.xfce4notifyd (xfce.xfce4-notifyd)
  • xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
  • xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
  • xfce.xfce4-screenshooter
  • xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
  • xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
  • xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
  • xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
  • xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
  • xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
  • xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
  • xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)
2 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/desktops/xfce/core/xfce4-panel/default.nix:44:15:

       |
    44 |   patches = [ ./xfce4-panel-datadir.patch ];
       |               ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near lib/attrsets.nix:362:7:

        |
    362 |       value = f name (catAttrs name sets);
        |       ^
    

@SuperSandro2000 SuperSandro2000 merged commit 7c6ef9c into NixOS:master May 6, 2021
@romildo romildo deleted the upd.xfce4-panel branch May 6, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants