zellij: 0.6.0 -> 0.8.0

[0x4A6F]

Motivation for this change

Upgrade to 0.8.0.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 121935 at f32dbbd3 run on x86_64-linux 1

1 package failed to build:

• zellij

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

---

Result of nixpkgs-review pr 121935 at f32dbbd3 run on aarch64-linux 1

1 package built successfully:

• zellij

[happysalada]

@0x4A6F it looks like there is a failure on x86_64-linux
here is the build log

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/rvb5v49dw97ldhxjc3jp9g5aks2ap10f-source
source root is source
Executing cargoSetupPostUnpackHook
unpacking source archive /nix/store/s65qbpcrcdypiydwchy3nbiic32dgzaj-zellij-0.7.0-vendor.tar.gz
Finished cargoSetupPostUnpackHook
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
Executing cargoSetupPostPatchHook
Validating consistency between /build/source//Cargo.lock and /build/zellij-0.7.0-vendor.tar.gz/Cargo.lock
Finished cargoSetupPostPatchHook
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Executing cargoBuildHook
++ env CC_x86_64-unknown-linux-gnu=/nix/store/zzvq5qwlm2xikawfqxb0q8gl2bw391a9-gcc-wrapper-10.2.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/zzvq5qwlm2xikawfqxb0q8gl2bw391a9-gcc-wrapper-10.2.0/bin/c++ CC_x86_64-unknown-linux-gnu=/nix/store/zzvq5qwlm2xikawfqxb0q8gl2bw391a9-gcc-wrapper-10.2.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/zzvq5qwlm2xikawfqxb0q8gl2bw391a9-gcc-wrapper-10.2.0/bin/c++ cargo build -j 2 --target x86_64-unknown-linux-gnu --frozen --release
   Compiling proc-macro2 v1.0.26
   Compiling unicode-xid v0.2.1
   Compiling syn v1.0.69
   Compiling libc v0.2.93
   Compiling cfg-if v1.0.0
   Compiling autocfg v1.0.1
   Compiling serde v1.0.125
   Compiling serde_derive v1.0.125
   Compiling value-bag v1.0.0-alpha.6
   Compiling lazy_static v1.4.0
   Compiling bitflags v1.2.1
   Compiling pin-project-lite v0.2.6
   Compiling log v0.4.14
   Compiling hashbrown v0.9.1
   Compiling version_check v0.9.3
   Compiling memchr v2.3.4
   Compiling ident_case v1.0.1
   Compiling fnv v1.0.7
   Compiling strsim v0.10.0
   Compiling futures-core v0.3.14
   Compiling target-lexicon v0.11.2
   Compiling adler v1.0.2
   Compiling smallvec v1.6.1
   Compiling cc v1.0.67
   Compiling gimli v0.23.0
   Compiling futures-io v0.3.14
   Compiling rustc-demangle v0.1.18
   Compiling cfg-if v0.1.10
   Compiling scopeguard v1.1.0
   Compiling object v0.23.0
   Compiling getrandom v0.2.2
   Compiling more-asserts v0.2.1
   Compiling cache-padded v1.1.1
   Compiling event-listener v2.5.1
   Compiling cranelift-codegen-shared v0.68.0
   Compiling fastrand v1.4.0
   Compiling wasmparser v0.65.0
   Compiling waker-fn v1.1.0
   Compiling parking v2.0.0
   Compiling proc-macro-hack v0.5.19
   Compiling once_cell v1.7.2
   Compiling crc32fast v1.2.1
   Compiling rayon-core v1.9.0
   Compiling ryu v1.0.5
   Compiling stable_deref_trait v1.2.0
   Compiling ppv-lite86 v0.2.10
   Compiling proc-macro-nested v0.1.7
   Compiling rustc-hash v1.1.0
   Compiling fallible-iterator v0.2.0
   Compiling either v1.6.1
   Compiling async-task v4.0.3
   Compiling pin-utils v0.1.0
   Compiling unicode-segmentation v1.7.1
   Compiling futures-sink v0.3.14
   Compiling byteorder v1.4.3
   Compiling vec-arena v1.1.0
   Compiling leb128 v0.2.4
   Compiling slab v0.4.2
   Compiling unicode-width v0.1.8
   Compiling inventory v0.1.10
   Compiling remove_dir_all v0.5.3
   Compiling wasmer-compiler-cranelift v1.0.2
   Compiling signal-hook v0.3.8
   Compiling radium v0.5.3
   Compiling futures-task v0.3.14
   Compiling atomic-waker v1.0.0
   Compiling lexical-core v0.7.5
   Compiling arrayvec v0.5.2
   Compiling serde_json v1.0.64
   Compiling ansi_term v0.11.0
   Compiling tap v1.0.1
   Compiling strsim v0.8.0
   Compiling utf8parse v0.1.1
   Compiling linked-hash-map v0.5.4
   Compiling wyz v0.2.0
   Compiling funty v1.1.0
   Compiling itoa v0.4.7
   Compiling static_assertions v1.1.0
   Compiling vec_map v0.8.2
   Compiling strum v0.20.0
   Compiling ansi_term v0.12.1
   Compiling utf8parse v0.2.0
   Compiling numtoa v0.1.0
   Compiling dtoa v0.4.8
   Compiling intmap v0.7.0
   Compiling colors-transform v0.2.11
   Compiling libloading v0.6.7
   Compiling memoffset v0.6.3
   Compiling indexmap v1.6.2
   Compiling miniz_oxide v0.4.4
   Compiling crossbeam-utils v0.8.3
   Compiling rayon v1.5.0
   Compiling tracing-core v0.1.17
   Compiling proc-macro-error-attr v1.0.4
   Compiling proc-macro-error v1.0.4
   Compiling nom v6.1.2
   Compiling wasmer-vm v1.0.2
   Compiling addr2line v0.14.1
   Compiling lock_api v0.4.3
   Compiling concurrent-queue v1.2.2
   Compiling async-mutex v1.4.0
   Compiling async-lock v2.4.0
   Compiling futures-channel v0.3.14
   Compiling heck v0.3.2
   Compiling wast v35.0.2
   Compiling textwrap v0.11.0
   Compiling unicode-truncate v0.2.0
   Compiling vte v0.3.3
   Compiling yaml-rust v0.4.5
   Compiling zellij-tile-extra v1.0.0 (/build/source/zellij-tile-extra)
   Compiling spinning v0.1.0
   Compiling async-channel v1.6.1
   Compiling strip-ansi-escapes v0.1.0
   Compiling wat v1.0.37
   Compiling quote v1.0.9
   Compiling num_cpus v1.13.0
   Compiling memmap2 v0.2.2
   Compiling socket2 v0.4.0
   Compiling which v4.1.0
   Compiling signal-hook-registry v1.3.0
   Compiling atty v0.2.14
   Compiling dirs-sys-next v0.1.2
   Compiling time v0.1.43
   Compiling termion v1.5.6
   Compiling termios v0.3.3
   Compiling region v2.2.0
   Compiling nix v0.19.1
   Compiling futures-lite v1.11.3
   Compiling bitvec v0.19.5
   Compiling vte_generate_state_changes v0.1.1
   Compiling rand_core v0.6.2
   Compiling clap v2.33.3
   Compiling directories-next v2.0.0
   Compiling backtrace v0.3.56
   Compiling crossbeam-epoch v0.9.3
   Compiling crossbeam-channel v0.5.1
   Compiling blocking v1.0.2
   Compiling async-executor v1.4.0
   Compiling vte v0.8.0
   Compiling rand_chacha v0.3.0
   Compiling darling_core v0.12.3
   Compiling ctor v0.1.20
   Compiling thiserror-impl v1.0.24
   Compiling tracing-attributes v0.1.15
   Compiling futures-macro v0.3.14
   Compiling ghost v0.1.2
   Compiling inventory-impl v0.1.10
   Compiling typetag-impl v0.1.7
   Compiling strum_macros v0.20.1
   Compiling crossbeam-deque v0.8.0
   Compiling rand v0.8.3
   Compiling wasmer-derive v1.0.2
   Compiling structopt-derive v0.4.14
   Compiling darling_macro v0.12.3
   Compiling thiserror v1.0.24
   Compiling futures-util v0.3.14
   Compiling tempfile v3.2.0
   Compiling darling v0.12.3
   Compiling structopt v0.3.21
   Compiling cranelift-entity v0.68.0
   Compiling serde_bytes v0.11.5
   Compiling bincode v1.3.3
   Compiling erased-serde v0.3.13
   Compiling generational-arena v0.2.8
   Compiling serde_yaml v0.8.17
   Compiling futures-executor v0.3.14
   Compiling enumset_derive v0.5.4
   Compiling regalloc v0.0.31
   Compiling polling v2.0.3
   Compiling tracing v0.1.25
   Compiling kv-log-macro v1.0.7
   Compiling gimli v0.22.0
   Compiling object v0.22.0
   Compiling wasmer-types v1.0.2
   Compiling cranelift-bforest v0.68.0
   Compiling typetag v0.1.7
   Compiling zellij-tile v1.1.0 (/build/source/zellij-tile)
   Compiling cranelift-codegen-meta v0.68.0
   Compiling futures v0.3.14
   Compiling enumset v1.0.6
   Compiling async-io v1.4.0
   Compiling interprocess v1.1.1
   Compiling async-global-executor v2.0.2
   Compiling async-process v1.0.2
   Compiling wasmer-compiler v1.0.2
   Compiling async-std v1.9.0
   Compiling cranelift-codegen v0.68.0
   Compiling wasmer-engine v1.0.2
   Compiling wasmer-object v1.0.2
   Compiling wasmer-engine-jit v1.0.2
   Compiling wasmer-engine-native v1.0.2
   Compiling cranelift-frontend v0.68.0
   Compiling wasmer v1.0.2
   Compiling wasmer-wasi v1.0.2
   Compiling zellij v0.7.0 (/build/source)
warning: function is never used: `hex_to_rgb`
  --> src/common/utils/shared.rs:46:8
   |
46 | pub fn hex_to_rgb(hex: &str) -> (u8, u8, u8) {
   |        ^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: function is never used: `detect_theme`
  --> src/common/utils/shared.rs:72:8
   |
72 | pub fn detect_theme(bg: PaletteColor) -> Theme {
   |        ^^^^^^^^^^^^

warning: 2 warnings emitted

    Finished release [optimized] target(s) in 7m 59s
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
@nix { "action": "setPhase", "phase": "checkPhase" }
running tests
Executing cargoCheckHook
++ cargo test -j 2 --release --target x86_64-unknown-linux-gnu --frozen -- --test-threads=2
   Compiling cfg-if v1.0.0
   Compiling lazy_static v1.4.0
   Compiling pin-project-lite v0.2.6
   Compiling hashbrown v0.9.1
   Compiling futures-core v0.3.14
   Compiling adler v1.0.2
   Compiling futures-io v0.3.14
   Compiling gimli v0.23.0
   Compiling smallvec v1.6.1
   Compiling cfg-if v0.1.10
   Compiling scopeguard v1.1.0
   Compiling object v0.23.0
   Compiling rustc-demangle v0.1.18
   Compiling cache-padded v1.1.1
   Compiling more-asserts v0.2.1
   Compiling parking v2.0.0
   Compiling fastrand v1.4.0
   Compiling wasmparser v0.65.0
   Compiling event-listener v2.5.1
   Compiling waker-fn v1.1.0
   Compiling once_cell v1.7.2
   Compiling ppv-lite86 v0.2.10
   Compiling fallible-iterator v0.2.0
   Compiling rustc-hash v1.1.0
   Compiling stable_deref_trait v1.2.0
   Compiling either v1.6.1
   Compiling async-task v4.0.3
   Compiling futures-sink v0.3.14
   Compiling pin-utils v0.1.0
   Compiling vec-arena v1.1.0
   Compiling slab v0.4.2
   Compiling leb128 v0.2.4
   Compiling cranelift-codegen-shared v0.68.0
   Compiling byteorder v1.4.3
   Compiling unicode-width v0.1.8
   Compiling remove_dir_all v0.5.3
   Compiling futures-task v0.3.14
   Compiling atomic-waker v1.0.0
   Compiling itoa v0.4.7
   Compiling arrayvec v0.5.2
   Compiling linked-hash-map v0.5.4
   Compiling wyz v0.2.0
   Compiling tap v1.0.1
   Compiling dtoa v0.4.8
   Compiling utf8parse v0.1.1
   Compiling ansi_term v0.11.0
   Compiling static_assertions v1.1.0
   Compiling funty v1.1.0
   Compiling strsim v0.8.0
   Compiling vec_map v0.8.2
   Compiling numtoa v0.1.0
   Compiling ansi_term v0.12.1
   Compiling similar v1.3.0
   Compiling uuid v0.8.2
   Compiling strum v0.20.0
   Compiling intmap v0.7.0
   Compiling utf8parse v0.2.0
   Compiling colors-transform v0.2.11
   Compiling libloading v0.6.7
   Compiling tracing-core v0.1.17
   Compiling lock_api v0.4.3
   Compiling addr2line v0.14.1
   Compiling concurrent-queue v1.2.2
   Compiling async-mutex v1.4.0
   Compiling async-lock v2.4.0
   Compiling futures-channel v0.3.14
   Compiling wast v35.0.2
   Compiling textwrap v0.11.0
   Compiling unicode-truncate v0.2.0
   Compiling yaml-rust v0.4.5
   Compiling vte v0.3.3
   Compiling zellij-tile-extra v1.0.0 (/build/source/zellij-tile-extra)
   Compiling libc v0.2.93
   Compiling bitflags v1.2.1
   Compiling memchr v2.3.4
   Compiling target-lexicon v0.11.2
   Compiling spinning v0.1.0
   Compiling async-channel v1.6.1
   Compiling ryu v1.0.5
   Compiling crc32fast v1.2.1
   Compiling proc-macro-nested v0.1.7
   Compiling radium v0.5.3
   Compiling wat v1.0.37
   Compiling strip-ansi-escapes v0.1.0
   Compiling num_cpus v1.13.0
   Compiling getrandom v0.2.2
   Compiling memmap2 v0.2.2
   Compiling socket2 v0.4.0
   Compiling which v4.1.0
   Compiling signal-hook-registry v1.3.0
   Compiling terminal_size v0.1.16
   Compiling atty v0.2.14
   Compiling dirs-sys-next v0.1.2
   Compiling time v0.1.43
   Compiling termion v1.5.6
   Compiling termios v0.3.3
   Compiling memoffset v0.6.3
   Compiling miniz_oxide v0.4.4
   Compiling crossbeam-utils v0.8.3
   Compiling region v2.2.0
   Compiling nix v0.19.1
   Compiling futures-lite v1.11.3
   Compiling lexical-core v0.7.5
   Compiling bitvec v0.19.5
   Compiling rand_core v0.6.2
   Compiling signal-hook v0.3.8
   Compiling console v0.14.1
   Compiling clap v2.33.3
   Compiling directories-next v2.0.0
   Compiling backtrace v0.3.56
   Compiling crossbeam-epoch v0.9.3
   Compiling crossbeam-channel v0.5.1
   Compiling blocking v1.0.2
   Compiling async-executor v1.4.0
   Compiling vte v0.8.0
   Compiling rand_chacha v0.3.0
   Compiling nom v6.1.2
   Compiling crossbeam-deque v0.8.0
   Compiling serde v1.0.125
   Compiling value-bag v1.0.0-alpha.6
   Compiling thiserror v1.0.24
   Compiling futures-util v0.3.14
   Compiling inventory v0.1.10
   Compiling rand v0.8.3
   Compiling rayon-core v1.9.0
   Compiling indexmap v1.6.2
   Compiling cranelift-entity v0.68.0
   Compiling serde_bytes v0.11.5
   Compiling bincode v1.3.3
   Compiling serde_json v1.0.64
   Compiling erased-serde v0.3.13
   Compiling generational-arena v0.2.8
   Compiling serde_yaml v0.8.17
   Compiling log v0.4.14
   Compiling futures-executor v0.3.14
   Compiling structopt v0.3.21
   Compiling tempfile v3.2.0
   Compiling rayon v1.5.0
   Compiling gimli v0.22.0
   Compiling object v0.22.0
   Compiling wasmer-types v1.0.2
   Compiling cranelift-bforest v0.68.0
   Compiling zellij-tile v1.1.0 (/build/source/zellij-tile)
   Compiling typetag v0.1.7
   Compiling insta v1.7.1
   Compiling regalloc v0.0.31
   Compiling polling v2.0.3
   Compiling tracing v0.1.25
   Compiling kv-log-macro v1.0.7
   Compiling futures v0.3.14
   Compiling wasmer-vm v1.0.2
   Compiling async-io v1.4.0
   Compiling enumset v1.0.6
   Compiling interprocess v1.1.1
   Compiling async-global-executor v2.0.2
   Compiling async-process v1.0.2
   Compiling wasmer-compiler v1.0.2
   Compiling cranelift-codegen v0.68.0
   Compiling async-std v1.9.0
   Compiling wasmer-engine v1.0.2
   Compiling wasmer-object v1.0.2
   Compiling cranelift-frontend v0.68.0
   Compiling wasmer-engine-jit v1.0.2
   Compiling wasmer-engine-native v1.0.2
   Compiling wasmer-compiler-cranelift v1.0.2
   Compiling wasmer v1.0.2
   Compiling wasmer-wasi v1.0.2
   Compiling zellij v0.7.0 (/build/source)
warning: unused import: `crate::common::utils::consts::SYSTEM_DEFAULT_CONFIG_DIR`
 --> src/common/setup.rs:1:5
  |
1 | use crate::common::utils::consts::SYSTEM_DEFAULT_CONFIG_DIR;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `utils::consts::ZELLIJ_IPC_PIPE`
  --> src/common/mod.rs:42:5
   |
42 | use utils::consts::ZELLIJ_IPC_PIPE;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: variant is never constructed: `IpcServer`
   --> src/common/errors.rs:144:5
    |
144 |     IpcServer,
    |     ^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: function is never used: `no_unbind_unbinds_none`
   --> src/common/input/./unit/keybinds_test.rs:139:4
    |
139 | fn no_unbind_unbinds_none() {
    |    ^^^^^^^^^^^^^^^^^^^^^^

warning: variant is never constructed: `ClosePane`
  --> src/common/screen.rs:49:5
   |
49 |     ClosePane(PaneId),
   |     ^^^^^^^^^^^^^^^^^

warning: constant is never used: `CONFIG_LOCATION`
 --> src/common/setup.rs:7:1
  |
7 | const CONFIG_LOCATION: &str = "/.config/zellij";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function is never used: `xdg_config_dir`
  --> src/common/setup.rs:69:8
   |
69 | pub fn xdg_config_dir() -> PathBuf {
   |        ^^^^^^^^^^^^^^

warning: function is never used: `home_config_dir`
  --> src/common/setup.rs:74:8
   |
74 | pub fn home_config_dir() -> Option<PathBuf> {
   |        ^^^^^^^^^^^^^^^

warning: constant is never used: `SYSTEM_DEFAULT_CONFIG_DIR`
  --> src/common/utils/consts.rs:12:1
   |
12 | pub const SYSTEM_DEFAULT_CONFIG_DIR: &str = "/etc/zellij";
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function is never used: `hex_to_rgb`
  --> src/common/utils/shared.rs:46:8
   |
46 | pub fn hex_to_rgb(hex: &str) -> (u8, u8, u8) {
   |        ^^^^^^^^^^

warning: function is never used: `detect_theme`
  --> src/common/utils/shared.rs:72:8
   |
72 | pub fn detect_theme(bg: PaletteColor) -> Theme {
   |        ^^^^^^^^^^^^

warning: variant is never constructed: `Error`
   --> src/common/mod.rs:118:5
    |
118 |     Error(String),
    |     ^^^^^^^^^^^^^

warning: 12 warnings emitted

    Finished release [optimized] target(s) in 8m 19s
     Running target/x86_64-unknown-linux-gnu/release/deps/zellij-a9e6ed735ba62ab1

running 154 tests
test client::panes::grid::grid_tests::vttest1_0 ... ok
test client::panes::grid::grid_tests::vttest1_1 ... ok
test client::panes::grid::grid_tests::vttest1_2 ... ok
test client::panes::grid::grid_tests::vttest1_3 ... ok
test client::panes::grid::grid_tests::vttest1_4 ... ok
test client::panes::grid::grid_tests::vttest1_5 ... ok
test client::panes::grid::grid_tests::vttest2_0 ... ok
test client::panes::grid::grid_tests::vttest2_1 ... ok
test client::panes::grid::grid_tests::vttest2_10 ... ok
test client::panes::grid::grid_tests::vttest2_11 ... ok
test client::panes::grid::grid_tests::vttest2_12 ... ok
test client::panes::grid::grid_tests::vttest2_13 ... ok
test client::panes::grid::grid_tests::vttest2_14 ... ok
test client::panes::grid::grid_tests::vttest2_3 ... ok
test client::panes::grid::grid_tests::vttest2_2 ... ok
test client::panes::grid::grid_tests::vttest2_5 ... ok
test client::panes::grid::grid_tests::vttest2_4 ... ok
test client::panes::grid::grid_tests::vttest2_7 ... ok
test client::panes::grid::grid_tests::vttest2_6 ... ok
test client::panes::grid::grid_tests::vttest2_8 ... ok
test client::panes::grid::grid_tests::vttest2_9 ... ok
test client::panes::grid::grid_tests::vttest3_0 ... ok
test common::input::config::config_test::try_from_cli_args_with_config ... ok
test common::input::config::config_test::try_from_cli_args_with_config_dir ... ok
test common::input::config::config_test::try_from_cli_args_default ... ok
test common::input::config::config_test::try_from_cli_args_with_config_dir_without_config ... ok
test common::input::keybinds::keybinds_test::from_keyaction_from_yaml_to_mode_keybindings ... ok
test common::input::config::config_test::try_from_cli_args_with_option_clean ... ok
test common::input::keybinds::keybinds_test::merge_keybinds_merges ... ok
test common::input::keybinds::keybinds_test::merge_keybinds_merges_different_keys ... ok
test common::input::keybinds::keybinds_test::merge_keybinds_overwrites_same_keys ... ok
test common::input::keybinds::keybinds_test::toplevel_unbind_unbinds_all ... ok
test common::input::keybinds::keybinds_test::merge_mode_keybinds_overwrites_same_keys ... ok
test tests::integration::basic::cannot_split_terminals_horizontally_when_active_terminal_is_too_small ... ok
test tests::integration::basic::cannot_split_largest_terminal_when_there_is_no_room ... ok
test tests::integration::basic::cannot_split_terminals_vertically_when_active_terminal_is_too_small ... ok
test tests::integration::basic::max_panes ... ok
test tests::integration::basic::scrolling_down_inside_a_pane ... ok
test tests::integration::basic::scrolling_page_up_inside_a_pane ... ok
test tests::integration::basic::scrolling_page_down_inside_a_pane ... ok
test tests::integration::basic::scrolling_up_inside_a_pane ... ok
test tests::integration::basic::split_largest_terminal ... ok
test tests::integration::basic::split_terminals_horizontally ... ok
test tests::integration::basic::starts_with_one_terminal ... ok
test tests::integration::basic::split_terminals_vertically ... ok
test tests::integration::close_pane::close_pane_with_another_pane_above_it ... ok
test tests::integration::basic::toggle_focused_pane_fullscreen ... ok
test tests::integration::close_pane::close_pane_with_another_pane_below_it ... ok
test tests::integration::close_pane::close_pane_with_another_pane_to_the_left ... ok
test tests::integration::close_pane::close_pane_with_another_pane_to_the_right ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_above_it ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_below_it ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_above_it_away_from_screen_edges ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_to_the_left ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_below_it_away_from_screen_edges ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_to_the_right ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_to_the_left_away_from_screen_edges ... ok
test tests::integration::close_pane::closing_last_pane_exits_app ... ok
test tests::integration::compatibility::bash_cursor_linewrap ... ok
test tests::integration::compatibility::clear_scroll_region ... ok
test tests::integration::close_pane::close_pane_with_multiple_panes_to_the_right_away_from_screen_edges ... ok
test tests::integration::compatibility::display_tab_characters_properly ... ok
test tests::integration::compatibility::emacs_longbuf ... ok
test tests::integration::compatibility::exa_plus_omf_theme ... ok
test tests::integration::compatibility::fish_paste_multiline ... ok
test tests::integration::compatibility::fish_select_tab_completion_options ... ok
test tests::integration::compatibility::fish_tab_completion_options ... ok
test tests::integration::compatibility::git_diff_scrollup ... ok
test tests::integration::compatibility::git_log ... ok
test tests::integration::compatibility::htop ... ok
test tests::integration::compatibility::htop_right_scrolling ... ok
test tests::integration::compatibility::htop_scrolling ... ok
test tests::integration::compatibility::neovim_insert_mode ... ok
test tests::integration::compatibility::run_bandwhich_from_fish_shell ... ok
test tests::integration::compatibility::top_and_quit ... ok
test tests::integration::compatibility::vim_ctrl_d ... ok
test tests::integration::compatibility::vim_ctrl_u ... ok
test tests::integration::compatibility::vim_overwrite ... ok
test tests::integration::compatibility::vim_scroll_region_down ... ok
test tests::integration::layouts::accepts_basic_layout ... ok
test tests::integration::move_focus_down::move_focus_down ... ok
test tests::integration::move_focus_left::move_focus_left ... ok
test tests::integration::move_focus_down::move_focus_down_to_the_most_recently_used_pane ... ok
test tests::integration::move_focus_right::move_focus_right ... ok
test tests::integration::move_focus_left::move_focus_left_to_the_most_recently_used_pane ... ok
test tests::integration::move_focus_up::move_focus_up ... ok
test tests::integration::move_focus_right::move_focus_right_to_the_most_recently_used_pane ... ok
test tests::integration::move_focus_up::move_focus_up_to_the_most_recently_used_pane ... ok
test tests::integration::resize_down::cannot_resize_down_when_pane_below_is_at_minimum_height ... ok
test tests::integration::resize_down::resize_down_with_multiple_panes_above ... ok
test tests::integration::resize_down::resize_down_with_pane_above ... ok
test tests::integration::resize_down::resize_down_with_pane_below ... ok
test tests::integration::resize_down::resize_down_with_panes_above_aligned_left_and_right_with_current_pane ... ok
test tests::integration::resize_down::resize_down_with_panes_above_aligned_left_and_right_with_panes_to_the_left_and_right ... ok
test tests::integration::resize_down::resize_down_with_panes_above_aligned_left_with_current_pane ... ok
test tests::integration::resize_down::resize_down_with_panes_above_and_below ... ok
test tests::integration::resize_down::resize_down_with_panes_above_aligned_right_with_current_pane ... ok
test tests::integration::resize_down::resize_down_with_panes_below_aligned_left_and_right_with_current_pane ... ok
test tests::integration::resize_down::resize_down_with_panes_below_aligned_left_and_right_with_to_the_left_and_right ... ok
test tests::integration::resize_down::resize_down_with_panes_below_aligned_left_with_current_pane ... ok
test tests::integration::resize_down::resize_down_with_panes_below_aligned_right_with_current_pane ... ok
test tests::integration::resize_left::cannot_resize_left_when_pane_to_the_left_is_at_minimum_width ... ok
test tests::integration::resize_left::resize_left_with_multiple_panes_to_the_left ... ok
test tests::integration::resize_left::resize_left_with_pane_to_the_left ... ok
test tests::integration::resize_left::resize_left_with_pane_to_the_right ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_left_aligned_bottom_with_current_pane ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_left_aligned_top_and_bottom_with_current_pane ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_left_aligned_top_and_bottom_with_panes_above_and_below ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_left_aligned_top_with_current_pane ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_left_and_right ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_right_aligned_bottom_with_current_pane ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_right_aligned_top_and_bottom_with_current_pane ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_right_aligned_top_and_bottom_with_panes_above_and_below ... ok
test tests::integration::resize_left::resize_left_with_panes_to_the_right_aligned_top_with_current_pane ... ok
test tests::integration::resize_right::cannot_resize_right_when_pane_to_the_left_is_at_minimum_width ... ok
test tests::integration::resize_right::resize_right_with_multiple_panes_to_the_left ... ok
test tests::integration::resize_right::resize_right_with_pane_to_the_left ... ok
test tests::integration::resize_right::resize_right_with_pane_to_the_right ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_left_aligned_bottom_with_current_pane ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_left_aligned_top_and_bottom_with_current_pane ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_left_aligned_top_and_bottom_with_panes_above_and_below ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_left_aligned_top_with_current_pane ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_left_and_right ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_right_aligned_bottom_with_current_pane ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_right_aligned_top_and_bottom_with_current_pane ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_right_aligned_top_and_bottom_with_panes_above_and_below ... ok
test tests::integration::resize_right::resize_right_with_panes_to_the_right_aligned_top_with_current_pane ... ok
test tests::integration::resize_up::cannot_resize_up_when_pane_above_is_at_minimum_height ... ok
test tests::integration::resize_up::resize_up_with_multiple_panes_above ... ok
test tests::integration::resize_up::resize_up_with_pane_above ... ok
test tests::integration::resize_up::resize_up_with_pane_below ... ok
test tests::integration::resize_up::resize_up_with_panes_above_aligned_left_and_right_with_current_pane ... ok
test tests::integration::resize_up::resize_up_with_panes_above_aligned_left_and_right_with_panes_to_the_left_and_right ... ok
test tests::integration::resize_up::resize_up_with_panes_above_aligned_left_with_current_pane ... ok
test tests::integration::resize_up::resize_up_with_panes_above_and_below ... ok
test tests::integration::resize_up::resize_up_with_panes_above_aligned_right_with_current_pane ... ok
test tests::integration::resize_up::resize_up_with_panes_below_aligned_left_and_right_with_current_pane ... ok
test tests::integration::resize_up::resize_up_with_panes_below_aligned_left_and_right_with_to_the_left_and_right ... ok
test tests::integration::resize_up::resize_up_with_panes_below_aligned_left_with_current_pane ... ok
test tests::integration::resize_up::resize_up_with_panes_below_aligned_right_with_current_pane ... ok
test tests::integration::tabs::close_last_pane_in_a_tab ... ok
test tests::integration::tabs::close_tab ... ok
test tests::integration::tabs::close_the_middle_tab ... ok
test tests::integration::tabs::close_the_tab_that_has_a_pane_in_fullscreen ... ok
test tests::integration::tabs::closing_last_tab_exits_the_app ... ok
test tests::integration::tabs::open_new_tab ... ok
test tests::integration::tabs::switch_to_next_tab ... ok
test tests::integration::terminal_window_resize::window_height_increase_with_one_pane ... ok
test tests::integration::tabs::switch_to_prev_tab ... ok
test tests::integration::terminal_window_resize::window_width_and_height_decrease_with_one_pane ... ok
stored new snapshot /build/source/src/tests/integration/snapshots/zellij__tests__integration__terminal_window_resize__window_width_decrease_with_one_pane.snap.new
test tests::integration::terminal_window_resize::window_width_decrease_with_one_pane ... FAILED
test tests::integration::terminal_window_resize::window_width_increase_with_one_pane ... ok
test tests::integration::toggle_fullscreen::move_focus_is_disabled_in_fullscreen ... ok
test tests::integration::toggle_fullscreen::adding_new_terminal_in_fullscreen ... ok

failures:

---- tests::integration::terminal_window_resize::window_width_decrease_with_one_pane stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Differences ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: src/tests/integration/snapshots/zellij__tests__integration__terminal_window_resize__window_width_decrease_with_one_pane.snap
Snapshot: window_width_decrease_with_one_pane
Source: src/tests/integration/terminal_window_resize.rs:42
-old snapshot
+new results
────────────────────────────────────────────────────────────────────────────────
snapshot_before_quit
────────────┬───────────────────────────────────────────────────────────────────
    0       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
    1       │-line11-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
    2       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
    3       │-line12-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
    4       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
    5       │-line13-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
    6       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
    7       │-line14-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
    8       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
    9       │-line15-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
   10       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
   11       │-line16-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
   12       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
   13       │-line17-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
   14       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
   15       │-line18-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
   16       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
   17       │-line19-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                               
   18       │-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa                                                                                          
          0 │+line1-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          1 │+line2-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          2 │+line3-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          3 │+line4-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          4 │+line5-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          5 │+line6-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          6 │+line7-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          7 │+line8-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          8 │+line9-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
          9 │+line10-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         10 │+line11-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         11 │+line12-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         12 │+line13-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         13 │+line14-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         14 │+line15-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         15 │+line16-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         16 │+line17-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         17 │+line18-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
         18 │+line19-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
   19    19 │ prompt $ █                                                                                                               
────────────┴───────────────────────────────────────────────────────────────────
To update snapshots run `cargo insta review`
thread 'tests::integration::terminal_window_resize::window_width_decrease_with_one_pane' panicked at 'snapshot assertion for 'window_width_decrease_with_one_pane' failed in line 42', /build/zellij-0.7.0-vendor.tar.gz/insta/src/runtime.rs:1036:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::integration::terminal_window_resize::window_width_decrease_with_one_pane

test result: FAILED. 153 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 17.65s

error: test failed, to rerun pass '--bin zellij'

Do you know by any chance why the failure is happening ?

Also, it looks like 0.8.0 just came out.

[happysalada]

Result of nixpkgs-review pr 121935 run on x86_64-darwin 1

1 package built:

• zellij

[0x4A6F]

Thanks @happysalada.

Strange, a local build was successful, and now with 0.8.0 the failure is gone.

[happysalada]

Result of nixpkgs-review pr 121935 run on x86_64-darwin 1

1 package built:

• zellij

[happysalada]

There was a hydra failure on darwin for the previous version. Let's see if it persists with this update.