routino: fix on darwin

[sikmir]

Motivation for this change

Steps to reproduce:

$ nix-shell -p routino --run "router+lib --version"
dyld: Library not loaded: @PREFIX@/lib/libroutino.dylib
  Referenced from: /nix/store/v3q3c61b84b1c2xnipxqzi4hd8ar3a41-routino-3.3.3/bin/router+lib
  Reason: image not found
/private/var/folders/wf/qxrs82v946n91pb5s71n3dy80000gp/T/nix-shell-80704-0/rc: line 1: 80710 Abort trap: 6           router+lib --version
$ nix-shell -p routino --run "otool -L `which router+lib` | grep libroutino"
    @PREFIX@/lib/libroutino.dylib (compatibility version 0.0.0, current version 0.0.0)

Fixed:

$ result/bin/router+lib --version
Routino version 3.3.3 <http://www.routino.org/> [Library version: 3.3.3, API version: 8]
$ otool -L result/bin/router+lib | grep libroutino
	/nix/store/hkkajcpv3phn5sn0q109x0l569dh2if4-routino-3.3.3/lib/libroutino.dylib (compatibility version 0.0.0, current version 0.0.0)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 121959 at ff27d38f run on aarch64-linux 1

2 packages built successfully:

• qmapshack
• routino

---

Result of nixpkgs-review pr 121959 at ff27d38f run on x86_64-linux 1

2 packages built successfully:

• qmapshack
• routino

3 suggestions:

• warning: unclear-gpl

  agpl3 is a deprecated license, please check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

  Near pkgs/tools/misc/routino/default.nix:42:5:

     |
  42 |     license = licenses.agpl3;
     |     ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/tools/misc/routino/default.nix:18:5:

     |
  18 |     (fetchpatch {
     |     ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/tools/misc/routino/default.nix:14:5:

     |
  14 |     (fetchpatch {
     |     ^
  

[dotlambda]

Would you mind fixing the license as suggested by @r-rmcgibbo?

[sikmir]

Would you mind fixing the license as suggested by @r-rmcgibbo?

Fixed. According to http://routino.org/#H_1_4:

This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version.