libvirt: 7.0.0 -> 7.3.0

[ryantm]

Motivation for this change

new stable verison

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 121965 at bacc804 run on x86_64-linux 1

2 packages failed to build:

• nixopsUnstable
• rubyPackages_3_0.ruby-libvirt

28 packages built successfully:

• collectd
• collectd-data
• docker-machine-kvm
• docker-machine-kvm2
• gnome3.gnome-boxes
• haskellPackages.libvirt-hs
• libguestfs
• libvirt
• libvirt-glib
• libvmi
• minikube
• minishift
• perl530Packages.SysVirt
• perl532Packages.SysVirt
• python38Packages.guestfs
• python38Packages.libvirt
• python39Packages.guestfs
• python39Packages.libvirt
• rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
• rubyPackages_2_7.ruby-libvirt
• terraform-full
• terraform-providers.libvirt
• vagrant
• virt-manager
• virt-manager-qt
• virt-top
• virt-viewer
• virtlyst

7 suggestions:

• warning: build-tools-in-build-inputs

  util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/development/libraries/libvirt/default.nix:63:3:

     |
  63 |   buildInputs = [
     |   ^
  

• warning: meson-cmake

  Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.

  Near pkgs/development/libraries/libvirt/default.nix:55:3:

     |
  55 |   nativeBuildInputs = [
     |   ^
  

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/development/libraries/libvirt/default.nix:2:32:

    |
  2 | , makeWrapper, autoreconfHook, fetchpatch
    |                                ^
  

• warning: unclear-gpl

  lgpl2 is a deprecated license, please check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

  Near pkgs/development/python-modules/libvirt/default.nix:25:5:

     |
  25 |     license = licenses.lgpl2;
     |     ^
  

• warning: build-tools-in-build-inputs

  pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/development/libraries/libvirt/default.nix:63:3:

     |
  63 |   buildInputs = [
     |   ^
  

• warning: unused-argument

  Unused argument: autoreconfHook.
  Near pkgs/development/libraries/libvirt/default.nix:2:16:

    |
  2 | , makeWrapper, autoreconfHook, fetchpatch
    |                ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/libraries/libvirt/default.nix:52:5:

     |
  52 |     ./0001-meson-patch-in-an-install-prefix-for-building-on-nix.patch
     |     ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

---

Result of nixpkgs-review pr 121965 at bacc804 run on aarch64-linux 1

1 package marked as broken and skipped:

• libvmi

1 package failed to build:

• nixopsUnstable

24 packages built successfully:

• collectd
• collectd-data
• docker-machine-kvm
• docker-machine-kvm2
• gnome3.gnome-boxes
• haskellPackages.libvirt-hs
• libguestfs
• libvirt
• libvirt-glib
• minikube
• minishift
• perl530Packages.SysVirt
• perl532Packages.SysVirt
• python38Packages.guestfs
• python38Packages.libvirt
• python39Packages.guestfs
• python39Packages.libvirt
• terraform-full
• terraform-providers.libvirt
• vagrant
• virt-manager
• virt-manager-qt
• virt-top
• virt-viewer

1 suggestion:

• warning: unclear-gpl

  lgpl2 is a deprecated license, please check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

  Near pkgs/development/python-modules/libvirt/default.nix:25:5:

     |
  25 |     license = licenses.lgpl2;
     |     ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

[SuperSandro2000]

Nixops fails to build.. https://gist.githubusercontent.com/r-rmcgibbo/1a550a13ea95903950c238b271e14261/raw/07f9015437f2b323d6baabd68b8de4c35ea33c64/nixopsUnstable

[ajs124]

Probably replaces #120819

[wedens]

Nixops fails to build.. https://gist.githubusercontent.com/r-rmcgibbo/1a550a13ea95903950c238b271e14261/raw/07f9015437f2b323d6baabd68b8de4c35ea33c64/nixopsUnstable

Note that it also failed to build on earlier versions (eg. 7.2.0).

[wedens]

Is there any chance it will make it to 21.05?

[jonringer]

Is there any chance it will make it to 21.05?

If it's ready to merge.

If it's a non-breaking change, it can always be backported as well.

[teto]

that's because the nixops-libvirtd plugin uses poetry and the lockfile uses an outdated python-libvirtd bindings. I would like to resume my usage of nixops-libvirtd and can fix it + add a flake. I've contributed to it in the past as shown by the open PRs https://github.com/nix-community/nixops-libvirtd . I think the current maintainers dont necessarily have the time to deal with that so if possible I would like to request merging rights on that repo too.

[teto]

closing since #130805 got merged.