Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/yggdrasil: set directory permissions before writing keys #121968

Merged
merged 1 commit into from May 8, 2021
Merged

nixos/yggdrasil: set directory permissions before writing keys #121968

merged 1 commit into from May 8, 2021

Conversation

gazally
Copy link
Contributor

@gazally gazally commented May 7, 2021

Motivation for this change

Address the security issue described in #121293.

@ehmry

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gazally
nixos/yggdrasil: set directory permissions before writing keys
3b845f7 
Remove the opportunity for someone to read the keys in between when
they are written and when the chmod is done.  Addresses NixOS#121293.
@ehmry ehmry merged commit 28f51d7 into NixOS:master May 8, 2021
@Stunkymonkey Stunkymonkey mentioned this pull request Feb 4, 2024
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gazally @ehmry