Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/zfs: Add defaultText for 'boot.zfs.package'-option #122001

Closed
wants to merge 1 commit into from

Conversation

queezle42
Copy link
Contributor

I noticed that boot.zfs.package had a default value of "zfs-user-2.0.4", which seemed very specific. Looking at the source shows that the value actually depends on config.boot.zfs.enableUnstable. This commit documents that by adding a defaultText attribute.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@queezle42
Copy link
Contributor Author

I opened this against nixos-unstable by accident. Brb with a new PR.

@queezle42 queezle42 closed this May 7, 2021
@queezle42 queezle42 deleted the patch-1 branch May 13, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant