Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/zfs: Add defaultText for 'boot.zfs.package'-option #122002

Merged
merged 1 commit into from May 13, 2021

Conversation

queezle42
Copy link
Contributor

I noticed that boot.zfs.package had a default value of "zfs-user-2.0.4", which seemed very specific. Looking at the source shows that the value actually depends on config.boot.zfs.enableUnstable. This commit documents that by adding a defaultText attribute.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@queezle42
Copy link
Contributor Author

/marvin opt-in
/status awaiting_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label May 8, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented May 8, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented May 11, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.


Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@queezle42
Copy link
Contributor Author

Oops, wrong Marvin state.
/status needs_reviewer

Copy link
Member

@thelegy thelegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelegy
Copy link
Member

thelegy commented May 13, 2021

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox May 13, 2021 21:31
@kevincox kevincox merged commit 22e7979 into NixOS:master May 13, 2021
@queezle42 queezle42 deleted the patch-1 branch May 13, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants