Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.kmapper: fix tests #122088

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

dotlambda
Copy link
Member

Motivation for this change

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

jonringer commented May 7, 2021

I should have fixed this on staging.... https://github.com/NixOS/nixpkgs/pull/121639/files

@dotlambda
Copy link
Member Author

We can still merge this. It uses pytestCheckHook and shouldn't create a merge conflict.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 7, 2021

Result of nixpkgs-review pr 122088 at 342a8db run on aarch64-linux 1

3 packages built successfully:
  • python38Packages.kmapper
  • python38Packages.scikit-tda
  • python39Packages.kmapper

Result of nixpkgs-review pr 122088 at 342a8db run on x86_64-linux 1

1 package failed to build:
1 package skipped due to time constraints:
  • python38Packages.scikit-tda
1 package built successfully:
  • python38Packages.kmapper

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@jonringer
Copy link
Contributor

We can still merge this. It uses pytestCheckHook and shouldn't create a merge conflict.

Ironically, my thoughts exactly 😁

@jonringer jonringer merged commit 29ca0ab into NixOS:master May 7, 2021
@dotlambda dotlambda deleted the kmapper-fix branch May 7, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants