arc-theme: 20210127 -> 20210412

[mkg20001]

Motivation for this change

Fix build

Things done

Updated src, using meson now

Currently broken as install fails due to mysteriously missing AUTHORS file

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[zimbatm]

Result of nixpkgs-review pr 122103 run on x86_64-linux 1

1 package failed to build:

• arc-theme

       > Running custom install script '/nix/store/68c5b0h2w2ab57sbas1b4m073ik8hlm5-bash-4.4-p23/bin/sh -c install -D -t $MESON_INSTALL_DESTDIR_PREFIX/share/themes/Arc-Lighter/xfwm4 /build/source/build/common/xfwm4/light/bottom-right-active.png'
       > Running custom install script '/nix/store/68c5b0h2w2ab57sbas1b4m073ik8hlm5-bash-4.4-p23/bin/sh -c install -D -t $MESON_INSTALL_DESTDIR_PREFIX/share/themes/Arc-Lighter/xfwm4 /build/source/build/common/xfwm4/light/bottom-right-inactive.png'
       > install: cannot stat 'AUTHORS': No such file or directory
       For full logs, run 'nix log /nix/store/32v1d48w0izkj3ps7pf0191252pb80dp-arc-theme-20210412.drv'.
error: 1 dependencies of derivation '/nix/store/rn1ygighgcnzb73g8a93ah4jc3vfchwz-review-shell.drv' failed to build

[r-rmcgibbo]

Result of nixpkgs-review pr 122103 at a8872c58 run on x86_64-linux 1

1 package failed to build:

• arc-theme

1 suggestion:

• warning: unnecessary-parallel-building

  Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

  Near pkgs/data/themes/arc/default.nix:44:3:

     |
  44 |   enableParallelBuilding = true;
     |   ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

---

Result of nixpkgs-review pr 122103 at a8872c58 run on aarch64-linux 1

1 package failed to build:

• arc-theme

1 suggestion:

• warning: unnecessary-parallel-building

  Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

  Near pkgs/data/themes/arc/default.nix:44:3:

     |
  44 |   enableParallelBuilding = true;
     |   ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

[moni-dz]

Currently broken as install fails due to mysteriously missing AUTHORS file

postInstall = ''
  install -Dm644 -t $out/share/doc/${pname} $src/AUTHORS $src/*.md
'';

This should fix the build.

AUTHORS and the various Markdown files aren't in the Meson build directory, so we copy them from src.

Also, ZHF #122042

[saschagrunert]

@mkg20001 let's fixup the build and get this merged :)

[kira-bruneau]

@mkg20001 This commit will also need to be rebased against master. The recent rename of gnome3 -> gnome will result in a successful, but incorrect merge to master that will fail to build. #122107.

[eyJhb]

@mkg20001 This commit will also need to be rebased against master. The recent rename of gnome3 -> gnome will result in a successful, but incorrect merge to master that will fail to build. #122107.

Yes, building against the latest unstable-small, gives me the following (pulling this in as a patch).

building '/nix/store/6vxgxmbza8yczp2ikid06c0gfi5aj2v2-pkgs-unstable-patched.drv'...
unpacking sources
unpacking source archive /nix/store/iv7g7xdvxh4wjzwn1pv0fvi138kkfy1i-nixpkgs-src
source root is nixpkgs-src
patching sources
applying patch /nix/store/7hswywzaqprvimxlfyzpng7626h8n61r-122103.patch
patching file pkgs/data/themes/arc/default.nix
Hunk #1 succeeded at 1 with fuzz 1.
installing
trace: warning: The option `services.gnome3.gnome-keyring.enable' defined in `/state/home/projects/nixos/nixus-setup/config/machines/eos/work-from-home.nix' has been renamed to `services.gnome.gnome-keyring.enable'.
error: undefined variable 'gnome3' at /nix/store/nx504r7z183adr3slgnkl196j65bkgf5-pkgs-unstable-patched/pkgs/data/themes/arc/default.nix:36:5
(use '--show-trace' to show detailed location information)

[chvp]

I posted a commit in #122086 that fixes the build and works correctly.

[moni-dz]

@ofborg eval

[moni-dz]

Result of nixpkgs-review pr 122103 run on x86_64-linux 1

1 package built:

• arc-theme

[moni-dz]

#122086 was merged already, so it's safe to close this