Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8812au: 5.6.4.2_35491.20200702 -> 5.9.3.2_20210427 #122121

Closed
wants to merge 2 commits into from

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Updated to latest version, which includes fixes for kernels >= 5.10. For ZHF #122042

Ran nixpkgs-review, and it now builds against all kernels except linux_hardened.

Also removed myself from maintainers, since I no longer actively use these devices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122121 at 6252752 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxPackages-libre.rtl8812au
  • linuxPackages_hardkernel_4_14.rtl8812au
  • linuxPackages_hardkernel_latest.rtl8812au
  • linuxPackages_latest-libre.rtl8812au
2 packages failed to build:
11 packages built successfully:
  • linuxPackages.rtl8812au (linuxPackages_5_10.rtl8812au)
  • linuxPackages_4_14.rtl8812au
  • linuxPackages_4_19.rtl8812au
  • linuxPackages_4_4.rtl8812au
  • linuxPackages_4_9.rtl8812au
  • linuxPackages_5_11.rtl8812au (linuxPackages_latest.rtl8812au)
  • linuxPackages_5_4.rtl8812au
  • linuxPackages_lqx.rtl8812au
  • linuxPackages_testing_bcachefs.rtl8812au
  • linuxPackages_xanmod.rtl8812au
  • linuxPackages_zen.rtl8812au
3 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/os-specific/linux/rtl8812au/default.nix:46:5:

       |
    46 |     license = licenses.gpl2;
       |     ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/os-specific/linux/rtl8812au/default.nix:48:5:

       |
    48 |     maintainers = with maintainers; [ ];
       |     ^
    
  • warning: name-and-version

    Did you mean to pass pname instead of name to mkDerivation?

    Near pkgs/os-specific/linux/rtl8812au/default.nix:4:3:

      |
    4 |   name = "rtl8812au-${kernel.version}-${version}";
      |   ^
    

    Near pkgs/os-specific/linux/rtl8812au/default.nix:5:3:

      |
    5 |   version = "5.9.3.2_20210427";
      |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@danielfullmer
Copy link
Contributor Author

Not relevant after #122188

@danielfullmer danielfullmer deleted the rtl8812-kernel-fix branch May 9, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants