Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tld: fix on darwin #122122

Merged
merged 1 commit into from May 8, 2021
Merged

python3Packages.tld: fix on darwin #122122

merged 1 commit into from May 8, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented May 7, 2021

Motivation for this change

https://nix-cache.s3.amazonaws.com/log/iq0p4cjq7f8wnz1qimk8ah5dmh1i6p86-python3.8-tld-0.12.5.drv
The initial error looks like it can be fixed by adding these scripts to $PATH, but then when doing so that triggers another error because these tests require network access. So I just disabled these two tests. But for some reason, disabledTestPaths doesn't work, so I just cleared the file.

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 7, 2021
@ofborg ofborg bot requested a review from fabaff May 7, 2021 23:43
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 8, 2021 •
edited

Result of nixpkgs-review pr 122122 at 0b4a3554 run on aarch64-linux 1

5 packages built successfully:
  • dnstwist
  • photon
  • python38Packages.tld
  • python39Packages.tld
  • wapiti
1 suggestion:
  • warning: unused-argument

    Unused argument: six.
    Near pkgs/development/python-modules/tld/default.nix:8:3:

      |
8 | , six
  |   ^

Result of nixpkgs-review pr 122122 at 0b4a3554 run on x86_64-linux 1

5 packages built successfully:
  • dnstwist
  • photon
  • python38Packages.tld
  • python39Packages.tld
  • wapiti
1 suggestion:
  • warning: unused-argument

    Unused argument: six.
    Near pkgs/development/python-modules/tld/default.nix:8:3:

      |
8 | , six
  |   ^

@siraben
Copy link
Member

siraben commented May 8, 2021

Result of nixpkgs-review pr 122122 run on x86_64-darwin 1

5 packages built:
  • dnstwist
  • photon
  • python38Packages.tld
  • python39Packages.tld
  • wapiti

siraben
siraben approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonringer
jonringer approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122122 run on x86_64-linux 1

5 packages built:
  • dnstwist
  • photon
  • python38Packages.tld
  • python39Packages.tld
  • wapiti

@jonringer jonringer merged commit 34e037b into NixOS:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@siraben siraben siraben approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmcgibbo @r-rmcgibbo @siraben @jonringer