Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeciv: build with gtk with gtkClient = true #122134

Merged
merged 1 commit into from Aug 3, 2021
Merged

freeciv: build with gtk with gtkClient = true #122134

merged 1 commit into from Aug 3, 2021

Conversation

fricklerhandwerk
Copy link
Contributor

the configure flag was missing, and now the freeciv-gtk3 binary will
be produced.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fricklerhandwerk fricklerhandwerk force-pushed the freeciv-gtk branch 2 times, most recently from 7cf8240 to 20ea6d0 Compare May 8, 2021 21:05
@ofborg ofborg bot requested a review from nbp May 8, 2021 21:28
@fricklerhandwerk
freeciv: build with gtk when gtkClient = true
10f9d7d 
the configure flag was missing, and now the `freeciv-gtk3` binary will
be produced.
@davidak
Copy link
Member

davidak commented Aug 3, 2021

Result of nixpkgs-review pr 122134 run on x86_64-linux 1

3 packages built:
  • freeciv
  • freeciv_gtk
  • freeciv_qt

davidak
davidak approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Builds, works

Screenshot from 2021-08-03 08-08-52

thanks for your contribution! sorry you had to wait so long

@davidak davidak merged commit 677dc1b into NixOS:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@davidak davidak davidak approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fricklerhandwerk @davidak @SuperSandro2000