Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navidrome: 0.40.0 -> 0.42.1 #122139

Merged
merged 1 commit into from May 8, 2021
Merged

navidrome: 0.40.0 -> 0.42.1 #122139

merged 1 commit into from May 8, 2021

Conversation

vs49688
Copy link
Contributor

@vs49688 vs49688 commented May 8, 2021

Motivation for this change

Updating.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from aciceri May 8, 2021 01:33
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122139 at 5dab4b0e run on x86_64-linux 1

1 package built successfully:
  • navidrome
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/misc/navidrome/default.nix:20:3:

       |
20 |   installPhase = ''
   |   ^

@SuperSandro2000 SuperSandro2000 merged commit fefb074 into NixOS:master May 8, 2021
@vs49688 vs49688 mentioned this pull request May 17, 2021
Closed
@vs49688 vs49688 deleted the navidrome branch August 21, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aciceri aciceri Awaiting requested review from aciceri

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vs49688 @r-rmcgibbo @SuperSandro2000