Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idrisPackages.data: remove broken package at 2018-03-19 #122181

Merged
merged 1 commit into from May 9, 2021

Conversation

divanorama
Copy link
Contributor

@divanorama divanorama commented May 8, 2021

Package doesn't compile (same error locally on x86_65 NixOS)
https://hydra.nixos.org/build/142422494/nixlog/2
And the repository is archived with latest commits being in 2019
https://github.com/jdevuyst/dependable-data-structures

Doesn't seem to be used by any other packages

ZHF: #122042

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@divanorama divanorama requested a review from infinisil as a code owner May 8, 2021 10:49
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove the refernce to this file pkgs/development/idris-modules/data.nix': No such file or directory

pkgs/development/idris-modules/default.nix
78:    data = callPackage ./data.nix {};

@jonringer
Copy link
Contributor

cc some idris people @veprbl

@veprbl
Copy link
Member

veprbl commented May 8, 2021

cc @brainrape as maintainer

@brainrake
Copy link
Contributor

brainrake commented May 9, 2021

Ok by me. Idris2 is out so Idris1 packages will probably be removed or migrated soon.

@infinisil infinisil merged commit aaec4a5 into NixOS:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants