Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethabi: 11.0.0 -> 13.0.0 #122205

Merged
merged 1 commit into from May 8, 2021
Merged

ethabi: 11.0.0 -> 13.0.0 #122205

merged 1 commit into from May 8, 2021

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented May 8, 2021 •
edited

Motivation for this change

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dbrock May 8, 2021 16:03
jonringer
jonringer reviewed May 8, 2021
View reviewed changes
pkgs/applications/blockchains/ethabi/add-Cargo-lock.patch
Comment on lines +7 to +9
+# This file is automatically @generated by Cargo.
+# It is not intended for manual editing.
+[[package]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not critical for this PR, but it's considered best practice to version control the lock file for applications https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html. Do you mind creating an issue upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They explicitly removed it at some point (link in PR desc), so I assume they have their reasons, but I can try!

jonringer
jonringer approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122205 run on x86_64-linux 1

1 package built:
  • ethabi

@jonringer jonringer merged commit a6fb029 into NixOS:master May 8, 2021
@asymmetric asymmetric deleted the ethabi-13 branch May 8, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

@dbrock dbrock Awaiting requested review from dbrock

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asymmetric @jonringer