Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mlrose: fix build #122207

Merged
merged 1 commit into from May 9, 2021
Merged

python3Packages.mlrose: fix build #122207

merged 1 commit into from May 9, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented May 8, 2021

Motivation for this change

https://nix-cache.s3.amazonaws.com/log/x0w9lb5sbwvi808ba82pk678zxhvrzns-python3.9-mlrose-1.3.0.drv
ZHF: #122042

Requires pulling a patch from a PR. The upstream is not too actively maintained anymore, it seems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 8, 2021

Result of nixpkgs-review pr 122207 at e3937c7c run on aarch64-linux 1

2 packages failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 122207 at e3937c7c run on x86_64-linux 1

1 package failed to build:
1 package built successfully:
  • python38Packages.mlrose

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

'';

propagatedBuildInputs = [ scikitlearn ];


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for nitpick

Suggested change

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented May 8, 2021

It seems like the test that failed on aarch64 + python39 might be flakey, because the python39 build does not fail on my x86_64-inux desktop. I'm going to poke a little bit at it, but if I don't see anything obvious I will just disable that test. I fixed the random seed, which is relevant for this tests (and lots of others in this package). Hopefully that helps.

@prusnak prusnak merged commit cf39516 into NixOS:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants