Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pika: add gevent to checkInputs #122229

Merged
merged 1 commit into from May 8, 2021

Conversation

mattmelling
Copy link
Contributor

Motivation for this change

fix unit test dependencies

https://nix-cache.s3.amazonaws.com/log/hv2sdrz3k6mpgqfsx9kzjdamgw3q82jw-python3.8-pika-1.2.0.drv

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented May 8, 2021

@GrahamcOfBorg build python3Packages.pika

@dotlambda
Copy link
Member

Unacceptable! #122170

@dotlambda
Copy link
Member

#122042 even mentions explicitly that you have to search for open PRs!!!

@prusnak
Copy link
Member

prusnak commented May 9, 2021

Sorry, I messed up.

@mattmelling
Copy link
Contributor Author

mattmelling commented May 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants