Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.exchangelib: fix build #122243

Merged
merged 2 commits into from May 8, 2021
Merged

python3Packages.exchangelib: fix build #122243

merged 2 commits into from May 8, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 8, 2021 •
edited

Motivation for this change

saw it was failing in #122119

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner May 8, 2021 21:28
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/122243

4 packages built:
python38Packages.backports-zoneinfo python38Packages.exchangelib python39Packages.backports-zoneinfo python39Packages.exchangelib

rmcgibbo
rmcgibbo approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 122243 run on x86_64-darwin 1

4 packages built:
  • python38Packages.backports-zoneinfo
  • python38Packages.exchangelib
  • python39Packages.backports-zoneinfo
  • python39Packages.exchangelib

Builds on darwin

@jonringer jonringer merged commit 283a7fe into NixOS:master May 8, 2021
@jonringer jonringer deleted the fix-exchangelib branch May 8, 2021 22:05
@jonringer jonringer changed the title python3Packages.exchangelib: fix build 357b7da python3Packages.exchangelib: fix build May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo rmcgibbo approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @rmcgibbo