Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monotone: 1.1 -> 1.1-unstable-2021-05-01 to move from insecure botan 1 #122251

Merged
merged 1 commit into from May 9, 2021

Conversation

7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented May 8, 2021

Motivation for this change

Botan 1 is out of support but now also has known vulnerabilities

Will self-merge after some time

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 8, 2021

Result of nixpkgs-review pr 122251 at eaf94c91 run on x86_64-linux 1

1 package built successfully:
  • monotone
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/version-management/monotone/default.nix:61:5:

       |
    61 |     license = licenses.gpl2;
       |     ^
    
  • warning: unused-argument

    Unused argument: fetchurl.
    Near pkgs/applications/version-management/monotone/default.nix:1:16:

      |
    1 | { lib, stdenv, fetchurl, fetchFromGitHub, boost, zlib, botan2, libidn
      |                ^
    

Result of nixpkgs-review pr 122251 at eaf94c91 run on aarch64-linux 1

1 package built successfully:
  • monotone

@7c6f434c
Copy link
Member Author

7c6f434c commented May 9, 2021

(unused fetchurl parameter is a sign of my hope to switch to an official upstream snapshot)

@7c6f434c 7c6f434c merged commit 0bb11cb into NixOS:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants