Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.importlib-metadata: 3.7.3 -> 4.0.1 #122252

Merged
merged 1 commit into from May 22, 2021
Merged

python3Packages.importlib-metadata: 3.7.3 -> 4.0.1 #122252

merged 1 commit into from May 22, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 8, 2021

Motivation for this change

Update to latest upstream release 4.0.1

Change log:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

I really wish python backport packages wouldn't break API all the time...

@jonringer
Copy link
Contributor

I would rather hold off on this until after the 14th, as there will probably be a lot of breakages that I would rather deal with after the release.

@jonringer jonringer added this to Blocked in Release Blocked PRs via automation May 8, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 8, 2021 •
edited

Result of nixpkgs-review pr 122252 at 61792ae run on aarch64-linux 1

854 packages marked as broken and skipped:
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • agdaPackages.iowa-stdlib
  • aldor
  • ams-lv2
  • amuleDaemon
  • aqemu
  • artyFX
  • ...
16356 packages skipped due to time constraints:
  • AusweisApp2
  • DisnixWebService
  • EBTKS
  • Fabric (python38Packages.Fabric)
  • MACS2
  • MIDIVisualizer
  • R
  • SDL_Pango
  • SDL_mixer
  • a2jmidid
  • ...
144 packages built successfully:
  • gi-docgen
  • jpylyzer (python38Packages.jpylyzer)
  • openjpeg
  • python38Packages.Babel
  • python38Packages.Mako
  • python38Packages.apipkg
  • python38Packages.astor
  • python38Packages.async_generator
  • python38Packages.backcall
  • python38Packages.backports-entry-points-selectable
  • python38Packages.beautifulsoup4
  • python38Packages.betamax
  • python38Packages.bleach
  • python38Packages.blinker
  • python38Packages.brotli
  • python38Packages.cachetools
  • python38Packages.chardet
  • python38Packages.click
  • python38Packages.cloudpickle
  • python38Packages.convertdate
  • python38Packages.ddt
  • python38Packages.django (python38Packages.django_2)
  • python38Packages.entrypoints
  • python38Packages.et_xmlfile
  • python38Packages.execnet
  • python38Packages.flake8
  • python38Packages.flaky
  • python38Packages.flit-core
  • python38Packages.freezegun
  • python38Packages.gunicorn
  • python38Packages.hijri-converter
  • python38Packages.html5lib
  • python38Packages.hyperlink
  • python38Packages.hypothesis
  • python38Packages.idna
  • python38Packages.importlib-metadata
  • python38Packages.intreehooks
  • python38Packages.iso8601
  • python38Packages.jdcal
  • python38Packages.jinja2
  • python38Packages.jupyter-packaging
  • python38Packages.jupyterlab-widgets
  • python38Packages.libevdev
  • python38Packages.mccabe
  • python38Packages.multidict
  • python38Packages.openpyxl
  • python38Packages.parso
  • python38Packages.pathpy
  • python38Packages.pep517
  • python38Packages.pickleshare
  • python38Packages.pluggy
  • python38Packages.poetry-core
  • python38Packages.py-cpuinfo
  • python38Packages.pyasn1-modules
  • python38Packages.pydocstyle
  • python38Packages.pylama
  • python38Packages.pymeeus
  • python38Packages.pytest (python38Packages.pytest_6)
  • python38Packages.pytest-asyncio
  • python38Packages.pytest-benchmark
  • python38Packages.pytestcov (python38Packages.pytest-cov)
  • python38Packages.pytest-expect
  • python38Packages.pytest-flake8
  • python38Packages.pytest-forked
  • python38Packages.pytest-freezegun
  • python38Packages.pytest-mock
  • python38Packages.pytestrunner (python38Packages.pytest-runner)
  • python38Packages.pytest-subtests
  • python38Packages.pytest-timeout
  • python38Packages.pytest-xdist (python38Packages.pytest_xdist)
  • python38Packages.pytest_4
  • python38Packages.pytoml
  • python38Packages.requests
  • python38Packages.responses
  • python38Packages.send2trash
  • python38Packages.simplejson
  • python38Packages.smartypants
  • python38Packages.sqlparse
  • python38Packages.tappy
  • python38Packages.text-unidecode
  • python38Packages.traitlets
  • python38Packages.typogrify
  • python38Packages.urllib3
  • python38Packages.virtualenv
  • python38Packages.webencodings
  • python38Packages.yarl
  • python39Packages.Babel
  • python39Packages.aniso8601
  • python39Packages.apipkg
  • python39Packages.astor
  • python39Packages.async_generator
  • python39Packages.backcall
  • python39Packages.backports-entry-points-selectable
  • python39Packages.blinker
  • python39Packages.click
  • python39Packages.cloudpickle
  • python39Packages.ddt
  • python39Packages.entrypoints
  • python39Packages.et_xmlfile
  • python39Packages.execnet
  • python39Packages.flake8
  • python39Packages.flaky
  • python39Packages.flit-core
  • python39Packages.freezegun
  • python39Packages.gunicorn
  • python39Packages.hijri-converter
  • python39Packages.hyperlink
  • python39Packages.idna
  • python39Packages.importlib-metadata
  • python39Packages.intreehooks
  • python39Packages.iso8601
  • python39Packages.jdcal
  • python39Packages.jinja2
  • python39Packages.locket
  • python39Packages.mccabe
  • python39Packages.multidict
  • python39Packages.pathpy
  • python39Packages.pep517
  • python39Packages.pickleshare
  • python39Packages.pluggy
  • python39Packages.py-cpuinfo
  • python39Packages.pyasn1-modules
  • python39Packages.pydocstyle
  • python39Packages.pylama
  • python39Packages.pymeeus
  • python39Packages.pytest (python39Packages.pytest_6)
  • python39Packages.pytest-asyncio
  • python39Packages.pytest-benchmark
  • python39Packages.pytestcov (python39Packages.pytest-cov)
  • python39Packages.pytest-expect
  • python39Packages.pytest-flake8
  • python39Packages.pytest-forked
  • python39Packages.pytest-freezegun
  • python39Packages.pytest-mock
  • python39Packages.pytestrunner (python39Packages.pytest-runner)
  • python39Packages.pytest-subtests
  • python39Packages.pytoml
  • python39Packages.send2trash
  • python39Packages.simplejson
  • python39Packages.sqlparse
  • python39Packages.text-unidecode
  • python39Packages.tzdata
  • python39Packages.webencodings
  • python39Packages.yarl

Result of nixpkgs-review pr 122252 at 61792ae run on x86_64-linux 1

747 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
17501 packages skipped due to time constraints:
  • AusweisApp2
  • DisnixWebService
  • EBTKS
  • Fabric (python38Packages.Fabric)
  • MACS2
  • MIDIVisualizer
  • OSCAR
  • R
  • SDL_Pango
  • SDL_mixer
  • ...
196 packages built successfully:
  • asciidoctor
  • gdk-pixbuf
  • gi-docgen
  • tracker (gnome.tracker)
  • pango (gnome2.pango)
  • jpylyzer (python38Packages.jpylyzer)
  • lasem
  • libinput
  • libnotify
  • openjpeg
  • python38Packages.Babel
  • python38Packages.Mako
  • python38Packages.PasteDeploy
  • python38Packages.aniso8601
  • python38Packages.apipkg
  • python38Packages.astor
  • python38Packages.astroid
  • python38Packages.async_generator
  • python38Packages.backcall
  • python38Packages.backports-entry-points-selectable
  • python38Packages.beautifulsoup4
  • python38Packages.betamax
  • python38Packages.bleach
  • python38Packages.blinker
  • python38Packages.brotli
  • python38Packages.cachecontrol
  • python38Packages.cachetools
  • python38Packages.cachy
  • python38Packages.chardet
  • python38Packages.cleo
  • python38Packages.click
  • python38Packages.clikit
  • python38Packages.cloudpickle
  • python38Packages.configobj
  • python38Packages.convertdate
  • python38Packages.dbus-python
  • python38Packages.ddt
  • python38Packages.django (python38Packages.django_2)
  • python38Packages.entrypoints
  • python38Packages.et_xmlfile
  • python38Packages.execnet
  • python38Packages.flake8
  • python38Packages.flaky
  • python38Packages.flask
  • python38Packages.flit-core
  • python38Packages.freezegun
  • python38Packages.gunicorn
  • python38Packages.h11
  • python38Packages.hijri-converter
  • python38Packages.html5lib
  • python38Packages.hyperframe
  • python38Packages.hyperlink
  • python38Packages.hypothesis
  • python38Packages.idna
  • python38Packages.importlib-metadata
  • python38Packages.importlib-resources
  • python38Packages.intreehooks
  • python38Packages.iso8601
  • python38Packages.isort
  • python38Packages.jdcal
  • python38Packages.jedi
  • python38Packages.jinja2
  • python38Packages.jupyter-packaging
  • python38Packages.jupyterlab-widgets
  • python38Packages.libevdev
  • python38Packages.mccabe
  • python38Packages.msgpack
  • python38Packages.multidict
  • python38Packages.openpyxl
  • python38Packages.parso
  • python38Packages.pastel
  • python38Packages.pathpy
  • python38Packages.pep517
  • python38Packages.pickleshare
  • python38Packages.pluggy
  • python38Packages.poetry-core
  • python38Packages.psutil
  • python38Packages.py-cpuinfo
  • python38Packages.pyasn1-modules
  • python38Packages.pycairo
  • python38Packages.pydocstyle
  • python38Packages.pygobject3
  • python38Packages.pylama
  • python38Packages.pymeeus
  • python38Packages.pytest (python38Packages.pytest_6)
  • python38Packages.pytest-asyncio
  • python38Packages.pytest-benchmark
  • python38Packages.pytestcov (python38Packages.pytest-cov)
  • python38Packages.pytest-expect
  • python38Packages.pytest-flake8
  • python38Packages.pytest-forked
  • python38Packages.pytest-freezegun
  • python38Packages.pytest-mock
  • python38Packages.pytest-relaxed
  • python38Packages.pytestrunner (python38Packages.pytest-runner)
  • python38Packages.pytest-subtests
  • python38Packages.pytest-timeout
  • python38Packages.pytest-xdist (python38Packages.pytest_xdist)
  • python38Packages.pytestCheckHook
  • python38Packages.pytestCheckHook_6_1
  • python38Packages.pytest_4
  • python38Packages.pytest_6_1
  • python38Packages.pytoml
  • python38Packages.requests
  • python38Packages.responses
  • python38Packages.send2trash
  • python38Packages.simplejson
  • python38Packages.smartypants
  • python38Packages.sqlparse
  • python38Packages.sybil
  • python38Packages.tappy
  • python38Packages.text-unidecode
  • python38Packages.traitlets
  • python38Packages.twisted
  • python38Packages.typogrify
  • python38Packages.urllib3
  • python38Packages.validators
  • python38Packages.virtualenv
  • python38Packages.webencodings
  • python38Packages.webob
  • python38Packages.websocket_client
  • python38Packages.werkzeug
  • python38Packages.wsproto
  • python38Packages.yarl
  • python39Packages.Babel
  • python39Packages.apipkg
  • python39Packages.astor
  • python39Packages.async_generator
  • python39Packages.backcall
  • python39Packages.backports-entry-points-selectable
  • python39Packages.beautifulsoup4
  • python39Packages.brotli
  • python39Packages.cachetools
  • python39Packages.click
  • python39Packages.cloudpickle
  • python39Packages.convertdate
  • python39Packages.ddt
  • python39Packages.entrypoints
  • python39Packages.et_xmlfile
  • python39Packages.execnet
  • python39Packages.flake8
  • python39Packages.flaky
  • python39Packages.flit-core
  • python39Packages.freezegun
  • python39Packages.gunicorn
  • python39Packages.hijri-converter
  • python39Packages.hyperlink
  • python39Packages.idna
  • python39Packages.importlib-metadata
  • python39Packages.intreehooks
  • python39Packages.iso8601
  • python39Packages.jdcal
  • python39Packages.jedi
  • python39Packages.jinja2
  • python39Packages.jupyter-packaging
  • python39Packages.jupyterlab-widgets
  • python39Packages.mccabe
  • python39Packages.multidict
  • python39Packages.openpyxl
  • python39Packages.parso
  • python39Packages.pathpy
  • python39Packages.pep517
  • python39Packages.pickleshare
  • python39Packages.pluggy
  • python39Packages.poetry-core
  • python39Packages.psutil
  • python39Packages.py-cpuinfo
  • python39Packages.pyasn1-modules
  • python39Packages.pydocstyle
  • python39Packages.pylama
  • python39Packages.pymeeus
  • python39Packages.pytest (python39Packages.pytest_6)
  • python39Packages.pytest-asyncio
  • python39Packages.pytest-benchmark
  • python39Packages.pytestcov (python39Packages.pytest-cov)
  • python39Packages.pytest-expect
  • python39Packages.pytest-flake8
  • python39Packages.pytest-forked
  • python39Packages.pytest-freezegun
  • python39Packages.pytest-mock
  • python39Packages.pytestrunner (python39Packages.pytest-runner)
  • python39Packages.pytest-subtests
  • python39Packages.pytest-timeout
  • python39Packages.pytest-xdist (python39Packages.pytest_xdist)
  • python39Packages.pytestCheckHook
  • python39Packages.pytoml
  • python39Packages.send2trash
  • python39Packages.simplejson
  • python39Packages.sqlparse
  • python39Packages.text-unidecode
  • python39Packages.traitlets
  • python39Packages.tzdata
  • python39Packages.urllib3
  • python39Packages.virtualenv
  • python39Packages.webencodings
  • python39Packages.yarl

@rmcgibbo
Copy link
Contributor

rmcgibbo commented May 8, 2021 •
edited

Wow, I'm extremely surprised that @r-rmcgibbo got no failures. There's still probably a lot out there though, but wow.

@jonringer
Copy link
Contributor 

17501 packages skipped due to time constraints:

I'm more concerned about importlib-metadata<4 in people's configs.

The jump to 3.0 caused a lot of regressions as well

@fabaff
Copy link
Member Author

fabaff commented May 9, 2021

We should definitely not hurry with this.

I have over 1k failures before I ran out of space locally...

@jonringer
Copy link
Contributor

The last ZHF staging-next cycle has been started.... This can be merged, however, still think it may be best to give the python ecosystem to adapt a bit.

@jonringer
Copy link
Contributor

We will have a longer staging-next cycle, so I think we can merge this

https://github.com/NixOS/nixpkgs/pull/122252

1 package built:
python3Packages.pandas

@jonringer jonringer merged commit afb9f51 into NixOS:staging May 22, 2021
Release Blocked PRs automation moved this from Blocked to No longer restricted :) May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
No open projects
Release Blocked PRs
No longer restricted :)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabaff @jonringer @r-rmcgibbo @rmcgibbo