Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.crate: fix build #122271

Merged
merged 1 commit into from May 9, 2021
Merged

python3Packages.crate: fix build #122271

merged 1 commit into from May 9, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented May 8, 2021

Motivation for this change

https://nix-cache.s3.amazonaws.com/log/jmbk647sxlwn3a6c4sm1wxw80ikcyhn7-python3.8-crate-0.26.0.drv
ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes May 9, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/122271

1 package failed to build:
csvkit

4 packages built:
python38Packages.agate-sql python38Packages.crate python39Packages.agate-sql python39Packages.crate

@jonringer jonringer merged commit da98a2d into NixOS:master May 9, 2021
@rmcgibbo rmcgibbo deleted the crate branch May 9, 2021 00:09
@ofborg ofborg bot requested a review from doronbehar May 9, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmcgibbo @jonringer