Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expat: 2.2.10 -> 2.3.0 #122275

Closed
wants to merge 1 commit into from
Closed

expat: 2.2.10 -> 2.3.0 #122275

wants to merge 1 commit into from

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented May 9, 2021 •
edited

Motivation for this change

Get bugfixes and improvements to users

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NixOS NixOS deleted a comment from github-actions bot May 9, 2021
@prusnak
Copy link
Member

prusnak commented May 9, 2021 •
edited

@hartwork this causes a massive rebuild can you please target this against the staging branch?

@hartwork hartwork changed the base branch from master to staging May 9, 2021 12:25
@hartwork
Copy link
Contributor Author

hartwork commented May 9, 2021 •
edited

@hartwork this causes a massive rebuild can you please target this against the staging branch?

@prusnak done

@jtojnar
Copy link
Contributor

jtojnar commented May 9, 2021

Changelog looks okay.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label May 9, 2021
@hartwork hartwork mentioned this pull request May 23, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hartwork @prusnak @jtojnar @SuperSandro2000