Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages<=4.9: mark broken on aarch64 #122290

Merged
merged 1 commit into from May 13, 2021
Merged

linuxPackages<=4.9: mark broken on aarch64 #122290

merged 1 commit into from May 13, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 9, 2021 •
edited

Motivation for this change

closes: #122281

ZHF: #122042

https://hydra.nixos.org/eval/1668552?filter=cryptodev&compare=1668435&full=#tabs-still-fail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
linuxPackages<=4.9: mark broken on aarch64
805bd1e 
Assembly errors, which causes all modules
to fail as well.
@jonringer jonringer requested a review from NeQuissimus May 9, 2021 02:20
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build linuxPackages_4_4.cryptodev

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build linuxPackages_4_9.cryptodev

@jonringer
Copy link
Contributor Author

been a few days, merging

@jonringer jonringer merged commit 8b348b3 into NixOS:master May 13, 2021
@jonringer jonringer deleted the mark-old-aarch-kernels-as-broken branch May 13, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moni-dz moni-dz moni-dz approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
6.topic: kernel 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @moni-dz