Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8192eu: 20200620 -> 20210403, mark as broken for aarch64 #122303

Merged
merged 1 commit into from May 13, 2021

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented May 9, 2021

Motivation for this change

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 9, 2021

Result of nixpkgs-review pr 122303 at 7c70f54f run on aarch64-linux 1

6 packages marked as broken and skipped:
  • linuxPackages-libre.rtl8192eu
  • linuxPackages_hardkernel_4_14.rtl8192eu
  • linuxPackages_hardkernel_latest.rtl8192eu
  • linuxPackages_latest-libre.rtl8192eu
  • linuxPackages_testing_bcachefs.rtl8192eu
  • linuxPackages_xanmod.rtl8192eu
11 packages failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 122303 at 7c70f54f run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxPackages-libre.rtl8192eu
  • linuxPackages_hardkernel_4_14.rtl8192eu
  • linuxPackages_hardkernel_latest.rtl8192eu
  • linuxPackages_latest-libre.rtl8192eu
13 packages built successfully:
  • linuxPackages.rtl8192eu (linuxPackages_5_10.rtl8192eu)
  • linuxPackages_4_14.rtl8192eu
  • linuxPackages_4_19.rtl8192eu
  • linuxPackages_4_4.rtl8192eu
  • linuxPackages_4_9.rtl8192eu
  • linuxPackages_5_11.rtl8192eu (linuxPackages_latest.rtl8192eu)
  • linuxPackages_5_4.rtl8192eu
  • linuxPackages_hardened.rtl8192eu
  • linuxPackages_latest_hardened.rtl8192eu
  • linuxPackages_lqx.rtl8192eu
  • linuxPackages_testing_bcachefs.rtl8192eu
  • linuxPackages_xanmod.rtl8192eu
  • linuxPackages_zen.rtl8192eu
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/os-specific/linux/rtl8192eu/default.nix:28:3:

       |
    28 |   installPhase = ''
       |   ^
    
  • warning: build-tools-in-build-inputs

    bc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/os-specific/linux/rtl8192eu/default.nix:22:3:

       |
    22 |   buildInputs = [ bc ];
       |   ^
    

@moni-dz moni-dz changed the title rtl8192eu: 20200620 -> 20210403 rtl8192eu: 20200620 -> 20210403, mark as broken for aarch64 May 9, 2021
@moni-dz
Copy link
Contributor Author

moni-dz commented May 9, 2021

Result of nixpkgs-review pr 122303 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages-libre.rtl8192eu
  • linuxPackages_latest-libre.rtl8192eu
13 packages built:
  • linuxPackages.rtl8192eu
  • linuxPackages_4_14.rtl8192eu
  • linuxPackages_4_19.rtl8192eu
  • linuxPackages_4_4.rtl8192eu
  • linuxPackages_4_9.rtl8192eu
  • linuxPackages_5_11.rtl8192eu
  • linuxPackages_5_4.rtl8192eu
  • linuxPackages_hardened.rtl8192eu
  • linuxPackages_latest_hardened.rtl8192eu
  • linuxPackages_lqx.rtl8192eu
  • linuxPackages_testing_bcachefs.rtl8192eu
  • linuxPackages_xanmod.rtl8192eu
  • linuxPackages_zen.rtl8192eu

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122303 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxPackages-libre.rtl8192eu
  • linuxPackages_hardkernel_4_14.rtl8192eu
  • linuxPackages_hardkernel_latest.rtl8192eu
  • linuxPackages_latest-libre.rtl8192eu
13 packages built:
  • linuxPackages.rtl8192eu (linuxPackages_5_10.rtl8192eu)
  • linuxPackages_4_14.rtl8192eu
  • linuxPackages_4_19.rtl8192eu
  • linuxPackages_4_4.rtl8192eu
  • linuxPackages_4_9.rtl8192eu
  • linuxPackages_5_11.rtl8192eu (linuxPackages_latest.rtl8192eu)
  • linuxPackages_5_4.rtl8192eu
  • linuxPackages_hardened.rtl8192eu
  • linuxPackages_latest_hardened.rtl8192eu
  • linuxPackages_lqx.rtl8192eu
  • linuxPackages_testing_bcachefs.rtl8192eu
  • linuxPackages_xanmod.rtl8192eu
  • linuxPackages_zen.rtl8192eu

@jonringer jonringer merged commit 18b1789 into NixOS:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants