Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: update #122323

Closed
wants to merge 1 commit into from
Closed

vimPlugins: update #122323

wants to merge 1 commit into from

Conversation

hoppla20
Copy link
Contributor

@hoppla20 hoppla20 commented May 9, 2021

Motivation for this change

neovim nightly was updated which broke telescope.nvim (Issue).
This was fixed and after updating all vim plugins, it's working again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 9, 2021

Result of nixpkgs-review pr 122323 at b2a90e91 run on x86_64-linux 1

28 packages built successfully:
  • spacevim
  • vimPlugins.chadtree
  • vimPlugins.completion-treesitter
  • vimPlugins.csv-vim
  • vimPlugins.deol-nvim
  • vimPlugins.fzf-vim
  • vimPlugins.git-messenger-vim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.hop-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-scrollview
  • vimPlugins.nvim-treesitter
  • vimPlugins.plenary-nvim
  • vimPlugins.popup-nvim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.telescope-fzf-writer-nvim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.telescope-nvim
  • vimPlugins.telescope-symbols-nvim
  • vimPlugins.telescope-z-nvim
  • vimPlugins.vim-airline
  • vimPlugins.vim-matchup
  • vimPlugins.vim-startify
  • vimPlugins.vim-terraform
  • vimPlugins.vim-xkbswitch
  • vimPlugins.which-key-nvim
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Result of nixpkgs-review pr 122323 at b2a90e91 run on aarch64-linux 1

2 packages built successfully:
  • spacevim
  • vimPlugins.telescope-fzy-native-nvim
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

@hoppla20 hoppla20 closed this May 10, 2021
@asymmetric
Copy link
Contributor

@hoppla20 why was this closed?

@hoppla20
Copy link
Contributor Author

@asymmetric because it was fixed in probably another merge. Probably someone also merge a update or adding a new vim plugin, which resolved the issue.

@hoppla20
Copy link
Contributor Author

Sorry for closing this issue without any comment

@hoppla20 hoppla20 deleted the update-vim-plugins branch June 1, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants