Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eksctl: 0.47.0 -> 0.48.0 #122331

Merged
merged 1 commit into from May 17, 2021
Merged

eksctl: 0.47.0 -> 0.48.0 #122331

merged 1 commit into from May 17, 2021

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 9, 2021

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/eksctl/versions.

meta.description for eksctl is: "A CLI for Amazon EKS"

meta.homepage for eksctl is: "https://github.com/weaveworks/eksctl"

meta.changelog for eksctl is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/fdmb4dfn88g083q5zfzg9bmmb1b8jgv8-eksctl-0.48.0/bin/eksctl passed the binary check.

  • 1 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 0.48.0 with grep in /nix/store/fdmb4dfn88g083q5zfzg9bmmb1b8jgv8-eksctl-0.48.0

  • found 0.48.0 in filename of file in /nix/store/fdmb4dfn88g083q5zfzg9bmmb1b8jgv8-eksctl-0.48.0

  • directory tree listing: https://gist.github.com/ee3772032e00150a40125ee95c239797

  • du listing: https://gist.github.com/9b0de4b71b34ff4778b35903acf8914f


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
eksctl
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/fdmb4dfn88g083q5zfzg9bmmb1b8jgv8-eksctl-0.48.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A eksctl https://github.com/r-ryantm/nixpkgs/archive/af36bbf907cfa47147be4af73559837e47d437ef.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fdmb4dfn88g083q5zfzg9bmmb1b8jgv8-eksctl-0.48.0
ls -la /nix/store/fdmb4dfn88g083q5zfzg9bmmb1b8jgv8-eksctl-0.48.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • eksctl

Maintainer pings

cc @xrelkd @Chili-Man @kalbasit for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 9, 2021

Result of nixpkgs-review pr 122331 at af36bbf run on x86_64-linux 1

1 package built successfully:
  • eksctl
1 suggestion:
  • error: no-flags-spaces

    buildFlags cannot contain spaces, please use buildFlagsArray in Bash.

    Near pkgs/tools/admin/eksctl/default.nix:20:3:

       |
    20 |   buildFlags = [ "-tags netgo" "-tags release" ];
       |   ^
    

Result of nixpkgs-review pr 122331 at af36bbf run on aarch64-linux 1

1 package built successfully:
  • eksctl
1 suggestion:
  • error: no-flags-spaces

    buildFlags cannot contain spaces, please use buildFlagsArray in Bash.

    Near pkgs/tools/admin/eksctl/default.nix:20:3:

       |
    20 |   buildFlags = [ "-tags netgo" "-tags release" ];
       |   ^
    

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122331 run on x86_64-linux 1

1 package built:
  • eksctl

@jonringer jonringer merged commit de56376 into NixOS:master May 17, 2021
@r-ryantm r-ryantm deleted the auto-update/eksctl branch May 18, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants