Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squeezelite: use ffmpeg 4 #122336

Merged
merged 1 commit into from May 9, 2021
Merged

squeezelite: use ffmpeg 4 #122336

merged 1 commit into from May 9, 2021

Conversation

samdoshi
Copy link
Contributor

@samdoshi samdoshi commented May 9, 2021

see #120705

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122336 at 8323b60 run on x86_64-linux 1

1 package built successfully:
  • squeezelite
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/audio/squeezelite/default.nix:66:5:

       |
    66 |     license = with licenses; [ gpl3 ] ++ optional dsdSupport bsd2;
       |     ^
    

@veprbl veprbl merged commit 52c27c3 into NixOS:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants