Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tremor-rs: build on darwin #122371

Merged
merged 1 commit into from May 10, 2021
Merged

Conversation

stephank
Copy link
Contributor

@stephank stephank commented May 9, 2021

Motivation for this change

Appears to work fine on Darwin with the usual tweaks. Probably also works on aarch64-{linux,darwin}?

cc @humancalico, sorry I didn't get around to this sooner. 馃檪

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122371 at 4774284d run on aarch64-linux 1

1 package failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@stephank
Copy link
Contributor Author

stephank commented May 9, 2021

No aarch64, looks like! I hope platforms = platforms.x86_64 is ok? Not sure if we should be specific, or leave open the possibility it works on 'exotic' platforms.

@humancalico
Copy link
Member

This is great. Thanks a lot @stephank

@SuperSandro2000 SuperSandro2000 merged commit 711ad46 into NixOS:master May 10, 2021
@stephank stephank deleted the fix-tremor-darwin branch May 11, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants