python3.pkgs.rtoml: init at 0.6.1 #122400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jonringer
reviewed
May 10, 2021
|
@ofborg eval |
fabaff
reviewed
May 10, 2021
Comment on lines
+41
to
+40
| preCheck = '' | ||
| cd tests | ||
| ''; |
There was a problem hiding this comment.
Looks like that we could use pytestFlagsArray here.
Suggested change
| preCheck = '' | |
| cd tests | |
| ''; | |
| pytestFlagsArray = [ "tests/" ]; |
There was a problem hiding this comment.
this results in 5 errors like this
E ImportError: cannot import name '_rtoml' from partially initialized module 'rtoml' (most likely due to a circular import) (/build/source/rtoml/__init__.py)
(the same occurs when neither preCheck or pytestFlagsArray are set)
dotlambda
requested changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
i wanted to compare its performance between
toml,rtoml,pytomlpp,json,simplejson,yaml,pyyamlandruamel yaml(results can be reproduced here)
and someone was asking about this on IRC
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/nix/store/1m6j3nd2x59xk9ghjj7n1wdz3573r702-python3.8-rtoml-0.6.1 99024384