Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitoxide: 0.6.0 -> 0.7.0 #122411

Merged
merged 1 commit into from May 10, 2021
Merged

gitoxide: 0.6.0 -> 0.7.0 #122411

merged 1 commit into from May 10, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented May 10, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented May 10, 2021 •
edited

@ofborg eval

(GitHub fix your API thx)

@ofborg ofborg bot requested a review from syberant May 10, 2021 02:55
@syberant
Copy link
Member

Result of nixpkgs-review pr 122411 1

1 package built:
  • gitoxide

syberant
syberant approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@syberant syberant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me (also tested on NixOS).

@SuperSandro2000 SuperSandro2000 merged commit f4d7c04 into NixOS:master May 10, 2021
@figsoda figsoda deleted the gitoxide branch May 10, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syberant syberant syberant approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@figsoda @cole-h @syberant @SuperSandro2000