Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccache: 4.2.1 → 4.3 #122492

Merged
merged 1 commit into from May 18, 2021
Merged

ccache: 4.2.1 → 4.3 #122492

merged 1 commit into from May 18, 2021

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented May 10, 2021 •
edited

Motivation for this change

Update to the latest version: https://github.com/ccache/ccache/releases/tag/v4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns

@kira-bruneau
Copy link
Contributor Author

Result of nixpkgs-review pr 122492 run on x86_64-linux 1

3 packages built:
  • ccache
  • ccacheStdenv
  • ccacheWrapper

@kira-bruneau
Copy link
Contributor Author

Result of nixpkgs-review pr 122492 run on x86_64-darwin 1

3 packages built:
  • ccache
  • ccacheStdenv
  • ccacheWrapper

@ofborg ofborg bot requested a review from r-burns May 10, 2021 22:07
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122492 at 3bd456e run on aarch64-linux 1

2 packages built successfully:
  • ccache
  • ccacheStdenv

r-burns
r-burns approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

@Ma27 Ma27 merged commit ed95b50 into NixOS:master May 18, 2021
@r-burns r-burns mentioned this pull request Jun 15, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kira-bruneau @r-rmcgibbo @SuperSandro2000 @r-burns @Ma27