Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.agate-excel: fix build #122495

Merged
merged 1 commit into from May 10, 2021
Merged

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

https://nix-cache.s3.amazonaws.com/log/gj2vn41aa7ccl3frmkcvssn4na8z3ngm-python3.8-agate-excel-0.2.3.drv
ZHF: #122042

I git bisected the failure, and pinpointed it to a bugfix in a dependency bump. I filed a ticket with upstream. Based on my read of the openpxyl issue, I determined that this failing test was probably erroneous, so I disabled it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 10, 2021

Result of nixpkgs-review pr 122495 at 2bed46d run on x86_64-linux 1

3 packages built successfully:
  • csvkit
  • python38Packages.agate-excel
  • python39Packages.agate-excel

Result of nixpkgs-review pr 122495 at 2bed46d run on aarch64-linux 1

3 packages built successfully:
  • csvkit
  • python38Packages.agate-excel
  • python39Packages.agate-excel

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122495 run on x86_64-linux 1

3 packages built:
  • csvkit
  • python38Packages.agate-excel
  • python39Packages.agate-excel

@jonringer jonringer merged commit b590df0 into NixOS:master May 10, 2021
@rmcgibbo rmcgibbo deleted the agate-excel branch May 11, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants