broot: 1.3.1 -> 1.4.0 #122571
broot: 1.3.1 -> 1.4.0 #122571
Conversation
|
Result of 1 package failed to build:
|
|
There was a compilation failure with missing things for oniguruma and libgit2. |
|
https://github.com/Canop/broot/commits/master |
There was a problem hiding this comment.
https://github.com/Canop/broot/commits/master
There was an update to lazy_regex 1.0, maybe that's why the failures appeared. Not sure though.
cargo tree says it's used by syntect.
pkgs/tools/misc/broot/default.nix
Outdated
| , oniguruma | ||
| , pkg-config | ||
| , libgit2 |
There was a problem hiding this comment.
Would be nice if this could be kept in order: lib -> stdenv -> library functions -> nativeBuildInputs -> buildInputs.
pkgs/tools/misc/broot/default.nix
Outdated
| ]; | ||
|
|
||
| buildInputs = lib.optionals stdenv.isDarwin [ | ||
| buildInputs = [ oniguruma libgit2 ] ++ lib.optionals stdenv.isDarwin [ |
There was a problem hiding this comment.
Please use alphabetical order.
|
@danieldk let me know if it works for you |
|
Thanks for the changes! Could you squash to two commits into one? |
|
Squashed, let me know if anything else. |
Motivation for this change
version update.
Here is the changelog
does not look like a big deal.
leaving it open in case you want to have a look at it @danieldk
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)