Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.56.0 -> 1.56.1 #122659

Merged
merged 1 commit into from May 12, 2021
Merged

vscode: 1.56.0 -> 1.56.1 #122659

merged 1 commit into from May 12, 2021

Conversation

samuela
Copy link
Member

@samuela samuela commented May 12, 2021

Motivation for this change

Upgrades vscode from 1.56.0 to 1.56.1

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: 735b47f107dbb896ad9c86eaa9668227.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Synthetica9 and eadwu May 12, 2021 01:03
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 12, 2021 •
edited

Result of nixpkgs-review pr 122659 at 2ca5a4e run on aarch64-linux 1

2 packages built successfully:
  • vscode
  • vscode-with-extensions

Result of nixpkgs-review pr 122659 at 2ca5a4e run on x86_64-linux 1

3 packages built successfully:
  • vscode
  • vscode-fhs
  • vscode-with-extensions

amaxine
amaxine approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified as working on x86_64.

@SuperSandro2000 SuperSandro2000 merged commit 65aee7c into NixOS:master May 12, 2021
@samuela samuela deleted the upkeep-bot/vscode-1.56.1-1620779139 branch May 12, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaxine amaxine amaxine approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samuela @r-rmcgibbo @amaxine @SuperSandro2000