Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xplr: add missing darwin dependencies #122668

Closed
wants to merge 1 commit into from
Closed

xplr: add missing darwin dependencies #122668

wants to merge 1 commit into from

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented May 12, 2021 •
edited

Motivation for this change

Follow up to #122515
ZHF: #122042

https://hydra.nixos.org/build/142878923/nixlog/2

draft for now until a darwin user can confirm this builds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 12, 2021
@moni-dz moni-dz marked this pull request as draft May 12, 2021 02:27
@ofborg ofborg bot requested review from sayanarijit and suryasr007 May 12, 2021 02:36
suryasr007
suryasr007 approved these changes May 12, 2021
View reviewed changes
Copy link

@suryasr007 suryasr007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@moni-dz
Copy link
Contributor Author

moni-dz commented May 15, 2021

Might be better off leaving this to darwin users.

@moni-dz moni-dz closed this May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryasr007 suryasr007 suryasr007 approved these changes

@sayanarijit sayanarijit sayanarijit approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moni-dz @suryasr007 @sayanarijit