Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.requests-http-signature: 0.1.0 -> 0.2.0 #122686

Merged
merged 1 commit into from May 19, 2021
Merged

python3Packages.requests-http-signature: 0.1.0 -> 0.2.0 #122686

merged 1 commit into from May 19, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 12, 2021

Motivation for this change

Update to latest upstream release 0.2.0 and fix build.

ZHF: #122042
Ref: https://hydra.nixos.org/build/142027045

CC @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from mmai May 12, 2021 07:49
@r-rmcgibbo

This comment has been minimized.

Sign in to view
@jonringer
Copy link
Contributor

please resolve conflicts

@fabaff fabaff force-pushed the fix-requests-http-signature branch 2 times, most recently from cc1bb44 to 94b0dc1 Compare May 14, 2021 07:47
@fabaff fabaff force-pushed the fix-requests-http-signature branch from 94b0dc1 to 9784a04 Compare May 19, 2021 09:51
@fabaff
Copy link
Member Author

fabaff commented May 19, 2021

Result of nixpkgs-review pr 122686 run on x86_64-linux 1

2 packages built:
  • python38Packages.requests-http-signature
  • python39Packages.requests-http-signature

@fabaff fabaff merged commit 7973682 into NixOS:master May 19, 2021
@fabaff fabaff deleted the fix-requests-http-signature branch May 19, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmai mmai Awaiting requested review from mmai

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @r-rmcgibbo @jonringer