php80Extensions.apcu_bc: mark as broken #122692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF #122042
Failing Hydra build: https://hydra.nixos.org/build/142591498
apcu_bc
[1] is a PHP extension which provides support for the older APCcaching-interface (i.e.
apc_fetch
,apc_store
etc.) on newer PHPversions. As the codebase wasn't touched since 2019 it's not really
surprising that it doesn't compile for PHP 8. Also, if people have
already managed to get their codebases running on PHP8, they're most
likely also using the newer APCu[2] interface.
I think it's okay to keep this as long as we support PHP 7.4 and drop
the package after that.
[1] https://pecl.php.net/package/apcu_bc
[2] https://www.php.net/manual/en/book.apcu.php
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)