gencfsm: 1.8.19 -> 1.9

[spacefrogg]

ZHF: #122042

@NixOS/nixos-release-managers

Motivation for this change

Unbreak the build.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 122698 at f4511593 run on x86_64-linux 1

1 package built successfully:

• gencfsm

7 suggestions:

• warning: build-tools-in-build-inputs

  automake is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/security/gencfsm/default.nix:15:3:

     |
  15 |   buildInputs = [ autoconf automake intltool libtool vala glib encfs
     |   ^
  

• warning: build-tools-in-build-inputs

  libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/security/gencfsm/default.nix:15:3:

     |
  15 |   buildInputs = [ autoconf automake intltool libtool vala glib encfs
     |   ^
  

• warning: build-tools-in-build-inputs

  wrapGAppsHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/security/gencfsm/default.nix:15:3:

     |
  15 |   buildInputs = [ autoconf automake intltool libtool vala glib encfs
     |   ^
  

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/tools/security/gencfsm/default.nix:19:15:

     |
  19 |   patches = [ ./makefile-mkdir.patch ];
     |               ^
  

• warning: build-tools-in-build-inputs

  autoconf is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/security/gencfsm/default.nix:15:3:

     |
  15 |   buildInputs = [ autoconf automake intltool libtool vala glib encfs
     |   ^
  

• warning: build-tools-in-build-inputs

  vala is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/security/gencfsm/default.nix:15:3:

     |
  15 |   buildInputs = [ autoconf automake intltool libtool vala glib encfs
     |   ^
  

• warning: build-tools-in-build-inputs

  intltool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/security/gencfsm/default.nix:15:3:

     |
  15 |   buildInputs = [ autoconf automake intltool libtool vala glib encfs
     |   ^