Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knot-dns: 3.0.5 -> 3.0.6 #122700

Merged
merged 1 commit into from May 12, 2021
Merged

knot-dns: 3.0.5 -> 3.0.6 #122700

merged 1 commit into from May 12, 2021

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 12, 2021

https://gitlab.nic.cz/knot/knot-dns/-/tags/v3.0.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented May 12, 2021

Let me try darwin build, just in case:
@GrahamcOfBorg build knot-resolver

@SuperSandro2000
Copy link
Member

Let me try darwin build, just in case:
@GrahamcOfBorg build knot-resolver

That is build automatically and the right mention is @ofborg

@vcunat
Copy link
Member Author

vcunat commented May 12, 2021

OK, I had old memories of darwin not triggering automatically, etc.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 12, 2021

Result of nixpkgs-review pr 122700 at bde27b4 run on x86_64-linux 1

2 packages built successfully:
  • knot-dns
  • knot-resolver

Result of nixpkgs-review pr 122700 at bde27b4 run on aarch64-linux 1

2 packages built successfully:
  • knot-dns
  • knot-resolver

@vcunat vcunat merged commit 65d6153 into NixOS:master May 12, 2021
@vcunat vcunat deleted the p/knot-dns-update branch May 12, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants