Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsce/MS-vsliveshare.vsliveshare: add V to maintainers #122731

Merged
merged 1 commit into from May 15, 2021
Merged

vsce/MS-vsliveshare.vsliveshare: add V to maintainers #122731

merged 1 commit into from May 15, 2021

Conversation

deviant
Copy link
Member

@deviant deviant commented May 12, 2021

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@deviant deviant requested a review from jonringer as a code owner May 12, 2021 14:12
@ofborg ofborg bot requested a review from jraygauthier May 12, 2021 14:23
@deviant deviant mentioned this pull request May 15, 2021
Merged
10 tasks
@deviant deviant changed the title vsce/MS-vsliveshare.vsliveshare: 1.0.4131 -> 1.0.4272 vsce/MS-vsliveshare.vsliveshare: add V to maintainers May 15, 2021
@deviant
Copy link
Member Author

deviant commented May 15, 2021

Per #116820 (comment)

I wanted to include this with a version bump or other such change to avoid submitting a useless PR, but a duplicate has been merged, so I've stripped that out.

@edef1c edef1c merged commit 10a4520 into NixOS:master May 15, 2021
@deviant deviant deleted the bump-vsls branch May 15, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deviant @edef1c