Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conan build failure caused by failing pyjwt testcase #122743

Merged
merged 1 commit into from May 12, 2021

Conversation

wirew0rm
Copy link
Contributor

Ignore a failing test in the downgraded pyjwt dependency.
See #122461 for another instance of the same problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ignore a failing thest in the downgraded pyjwt dependency.
See NixOS#122461 for another instance of the same problem.
@wirew0rm
Copy link
Contributor Author

some more context:

cc @bjornfor because he did the downgrade to 1.7.1

Shortly afterwards the pyjwt was upgraded from 2.0.1 to 2.1.0, where a previously suprressed test now passes and the suppression was removed.
There were attempts to suppress this test conditionally depending on the version, which didn't work: #122380

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjornfor bjornfor merged commit 362bc67 into NixOS:master May 12, 2021
@bjornfor
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants