Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modemmanager: 1.14.10 -> 1.14.12 #122747

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented May 12, 2021

Motivation for this change

Version bump
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/blob/1.14.12/NEWS

ModemManager 1.14.12
-------------------------------------------
This is a new bugfix release of ModemManager.

 * MBIM:
   ** Plug memleak in disconnection logic.
   ** Don't fail IPv4v6 connection attempt if only IPv4 succeeds.

 * QMI:
   ** Fix network registration cancellation logic with asserts disabled.

1.16.x (1.16.4 specifically) is already available but I haven't had the time/energy to actually look at why its tests are failing right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks okay.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label May 12, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 12, 2021

Result of nixpkgs-review pr 122747 at 907d348 run on aarch64-linux 1

124 packages marked as broken and skipped:
  • gnome.gnome-documents
  • libsForQt512.akonadi-calendar
  • libsForQt512.akonadiconsole
  • libsForQt512.alkimia
  • libsForQt512.baloo-widgets
  • libsForQt512.bomber
  • libsForQt512.bovo
  • libsForQt512.calendarsupport
  • libsForQt512.discover
  • libsForQt512.dolphin
  • ...
399 packages skipped due to time constraints:
  • adapta-gtk-theme
  • almanah
  • apostrophe
  • arc-theme
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • astroid
  • balsa
  • bibata-cursors
  • ...
42 packages built successfully:
  • appgate-sdp
  • clight
  • flatpak
  • geoclue2
  • glib-networking (gnome.glib-networking ,gnome.glib_networking)
  • gnome.gnome-clocks
  • gnome.gnome-settings-daemon (gnome.gnome_settings_daemon)
  • gnome.gnome-weather
  • gnome.mutter
  • gnome.mutter334 (pantheon.mutter)
  • networkmanager-iodine (gnome.networkmanager-iodine)
  • networkmanagerapplet (gnome.networkmanagerapplet)
  • libnma
  • libproxy
  • libsForQt5.kdelibs4support (libsForQt515.kdelibs4support ,plasma5Packages.kdelibs4support)
  • libsForQt5.networkmanager-qt (libsForQt515.networkmanager-qt ,plasma5Packages.networkmanager-qt)
  • libsForQt514.kdelibs4support
  • modemmanager
  • networkmanager
  • networkmanager_dmenu
  • ostree
  • pantheon.elementary-dpms-helper
  • pantheon.elementary-settings-daemon
  • pantheon.gala
  • pantheon.pantheon-agent-geoclue2
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-network
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.wingpanel
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • phoc
  • python38Packages.python-dbusmock
  • redshift
  • sublime-music

Result of nixpkgs-review pr 122747 at 907d348 run on x86_64-linux 1

130 packages marked as broken and skipped:
  • gimpPlugins.exposureBlend
  • gimpPlugins.texturize
  • glimpsePlugins.exposureBlend
  • glimpsePlugins.texturize
  • gnome.gnome-documents
  • googleearth-pro
  • libsForQt512.akonadi-calendar
  • libsForQt512.akonadiconsole
  • libsForQt512.alkimia
  • libsForQt512.baloo-widgets
  • ...
472 packages skipped due to time constraints:
  • adapta-gtk-theme
  • almanah
  • apostrophe
  • arc-theme
  • areca
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • astroid
  • aws-workspaces
  • ...
42 packages built successfully:
  • appgate-sdp
  • clight
  • flatpak
  • geoclue2
  • glib-networking (gnome.glib-networking ,gnome.glib_networking)
  • gnome.gnome-clocks
  • gnome.gnome-settings-daemon (gnome.gnome_settings_daemon)
  • gnome.gnome-weather
  • gnome.mutter
  • gnome.mutter334 (pantheon.mutter)
  • networkmanager-fortisslvpn (gnome.networkmanager-fortisslvpn)
  • networkmanagerapplet (gnome.networkmanagerapplet)
  • libnma
  • libproxy
  • libsForQt5.kdelibs4support (libsForQt515.kdelibs4support ,plasma5Packages.kdelibs4support)
  • libsForQt5.networkmanager-qt (libsForQt515.networkmanager-qt ,plasma5Packages.networkmanager-qt)
  • libsForQt514.kdelibs4support
  • modemmanager
  • networkmanager
  • networkmanager_dmenu
  • ostree
  • pantheon.elementary-dpms-helper
  • pantheon.elementary-settings-daemon
  • pantheon.gala
  • pantheon.pantheon-agent-geoclue2
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-network
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.wingpanel
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • phoc
  • python38Packages.python-dbusmock
  • redshift
  • sublime-music
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/tools/networking/modem-manager/default.nix:41:5:

       |
    41 |     maintainers = [ ];
       |     ^
    

@jtojnar jtojnar merged commit 293d6a8 into NixOS:master May 18, 2021
@amaxine amaxine deleted the modemmanager_1.14.12 branch June 13, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants