Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono: 5 -> 6 #122759

Merged
merged 2 commits into from May 17, 2021
Merged

mono: 5 -> 6 #122759

merged 2 commits into from May 17, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
6 packages marked as broken and skipped:
dotnetPackages.ExtCore gdata-sharp monodevelop python38Packages.pythonnet python39Packages.pythonnet ue4

20 packages failed to build:
appindicator-sharp bless dotnetPackages.FSharpAutoComplete dotnetPackages.MonoAddins dotnetPackages.Projekt gio-sharp gnome-sharp gtk-sharp-2_0 gtk-sharp-3_0 gtk-sharp-beans hyena mono-addins notify-sharp pdfmod pinta snapdragon-profiler sparkleshare supertux-editor tomboy webkit2-sharp

135 packages built:
avrdudess boogie bottles btcpayserver ckan convchain dafny dbus-sharp-1_0 dbus-sharp-glib-1_0 dbus-sharp-glib-2_0 dotnetPackages.Autofac dotnetPackages.Deedle dotnetPackages.ExcelDna dotnetPackages.ExcelDnaRegistration dotnetPackages.FSharpCompilerCodeDom dotnetPackages.FSharpCompilerService dotnetPackages.FSharpCompilerTools dotnetPackages.FSharpCore302 dotnetPackages.FSharpCore3125 dotnetPackages.FSharpCore4001 dotnetPackages.FSharpCore4117 dotnetPackages.FSharpData dotnetPackages.FSharpData225 dotnetPackages.FSharpDataSQLProvider dotnetPackages.FSharpFormatting dotnetPackages.Fake dotnetPackages.Fantomas dotnetPackages.FsCheck dotnetPackages.FsCheck262 dotnetPackages.FsCheckNunit dotnetPackages.FsLexYacc dotnetPackages.FsLexYacc706 dotnetPackages.FsLexYaccRuntime dotnetPackages.FsPickler dotnetPackages.FsUnit dotnetPackages.FuzzyLogicLibrary dotnetPackages.GitVersionTree dotnetPackages.MathNetNumerics dotnetPackages.MaxMindDb dotnetPackages.MaxMindGeoIP2 dotnetPackages.MicrosoftDiaSymReader dotnetPackages.MicrosoftDiaSymReaderPortablePdb dotnetPackages.MonoNat dotnetPackages.NDeskOptions dotnetPackages.NUnit dotnetPackages.NUnit3 dotnetPackages.NUnit350 dotnetPackages.NUnitConsole dotnetPackages.NUnitRunners dotnetPackages.NewtonsoftJson dotnetPackages.Nuget dotnetPackages.OpenNAT dotnetPackages.Paket dotnetPackages.RestSharp dotnetPackages.SharpFont dotnetPackages.SharpZipLib dotnetPackages.SmartIrc4net dotnetPackages.StyleCopMSBuild dotnetPackages.StyleCopPlusMSBuild dotnetPackages.Suave dotnetPackages.SystemCollectionsImmutable dotnetPackages.SystemCollectionsImmutable131 dotnetPackages.SystemReflectionMetadata dotnetPackages.SystemValueTuple dotnetPackages.UnionArgParser dotnetbuildhelpers duplicati eventstore foundationdb foundationdb51 foundationdb52 foundationdb60 fsharp fsharp41 github-runner haxePackages.hxcs jackett juniper keepass keepass-keeagent keepass-keefox keepass-keepasshttp keepass-otpkeyprov kodiPackages.steam-launcher lidarr lutris midisheetmusic mono mono5 msbuild nbxplorer omnisharp-roslyn openra openraPackages.engines.bleed openraPackages.engines.playtest openraPackages.mods.ca openraPackages.mods.d2 openraPackages.mods.dr openraPackages.mods.gen openraPackages.mods.kknd openraPackages.mods.mw openraPackages.mods.ra2 openraPackages.mods.raclassic openraPackages.mods.rv openraPackages.mods.sp openraPackages.mods.ss openraPackages.mods.ura openraPackages.mods.yr opentabletdriver osu-lazer pash playonlinux protontricks python-language-server python38Packages.foundationdb51 python38Packages.foundationdb52 python38Packages.foundationdb60 python38Packages.foundationdb61 python39Packages.foundationdb51 python39Packages.foundationdb52 python39Packages.foundationdb60 python39Packages.foundationdb61 radarr ryujinx sonarr steam steam-run steam-run-native steam-tui steamcmd syntex taglib-sharp vscode-extensions.ms-vscode.cpptools wasabibackend wavefunctioncollapse

I guess we should make gtk-sharp-2_0 use mono5. Do all depending packages also have to use mono5 then?

@dotlambda dotlambda requested a review from jonringer as a code owner May 12, 2021 19:47
@dotlambda dotlambda requested a review from kevincox May 12, 2021 19:50
@ofborg ofborg bot requested a review from ericdallo May 12, 2021 19:57
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 12, 2021 •
edited

Result of nixpkgs-review pr 122759 at 4b0dd79 run on aarch64-linux 1

15 packages marked as broken and skipped:
  • bless
  • dotnetPackages.ExtCore
  • gdata-sharp
  • monodevelop
  • python38Packages.foundationdb51
  • python38Packages.foundationdb52
  • python38Packages.foundationdb60
  • python38Packages.foundationdb61
  • python38Packages.pythonnet
  • python39Packages.foundationdb51
  • ...
66 packages skipped due to time constraints:
  • boogie (dotnetPackages.Boogie)
  • btcpayserver
  • ckan
  • convchain
  • dafny (dotnetPackages.Dafny)
  • dbus-sharp-1_0
  • dbus-sharp-glib-1_0
  • dbus-sharp-glib-2_0
  • dotnetPackages.ExcelDna
  • dotnetPackages.ExcelDnaRegistration
  • ...
3 packages built successfully:
  • avrdudess
  • juniper
  • mono
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/omnisharp-roslyn/default.nix:28:3:

       |
28 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 122759 at 4b0dd79 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • dotnetPackages.ExtCore
  • gdata-sharp
  • monodevelop
  • python38Packages.pythonnet
  • python39Packages.pythonnet
  • scallion
  • ue4
118 packages skipped due to time constraints:
  • appindicator-sharp
  • bless
  • boogie (dotnetPackages.Boogie)
  • bottles
  • btcpayserver
  • ckan
  • convchain
  • dafny (dotnetPackages.Dafny)
  • dbus-sharp-1_0
  • dbus-sharp-glib-1_0
  • ...
38 packages built successfully:
  • avrdudess
  • dotnetPackages.Deedle
  • dotnetPackages.FSharpCompilerCodeDom
  • dotnetPackages.FSharpData225
  • dotnetPackages.Fantomas
  • dotnetPackages.FsCheck
  • dotnetPackages.FsCheck262
  • dotnetPackages.FsCheckNunit
  • dotnetPackages.FsLexYacc706
  • dotnetPackages.FsLexYaccRuntime
  • dotnetPackages.FsPickler
  • dotnetPackages.FsUnit
  • dotnetPackages.FuzzyLogicLibrary
  • dotnetPackages.MaxMindGeoIP2
  • dotnetPackages.MicrosoftDiaSymReaderPortablePdb
  • dotnetPackages.MonoNat
  • dotnetPackages.NUnit (dotnetPackages.NUnit2)
  • dotnetPackages.NUnit3
  • dotnetPackages.NUnit350
  • dotnetPackages.NUnitConsole
  • dotnetPackages.NewtonsoftJson
  • dotnetPackages.OpenNAT
  • dotnetPackages.SharpFont
  • dotnetPackages.SharpZipLib
  • dotnetPackages.SmartIrc4net
  • dotnetPackages.StyleCopPlusMSBuild
  • dotnetPackages.Suave
  • dotnetPackages.SystemCollectionsImmutable
  • dotnetPackages.SystemCollectionsImmutable131
  • dotnetPackages.SystemReflectionMetadata
  • dotnetPackages.SystemValueTuple
  • dotnetbuildhelpers
  • juniper
  • keepass-keeagent
  • keepass-keepasshttp
  • keepass-keepassrpc
  • keepass-otpkeyprov
  • mono
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/omnisharp-roslyn/default.nix:28:3:

       |
28 |   installPhase = ''
   |   ^

@dotlambda dotlambda requested a review from dasj19 May 12, 2021 20:23
@Mathnerd314
Copy link
Contributor

Mathnerd314 commented May 12, 2021 •
edited

Well, supertux-editor is abandoned at this point (there is an in-game editor instead), so it should probably be removed / marked as broken, no point in wasting effort on it.

@dotlambda
Copy link
Member Author

Well, supertux-editor is abandoned at this point (there is an in-game editor instead), so it should probably be removed

Would you mind doing that in a PR?

@Mathnerd314 Mathnerd314 mentioned this pull request May 12, 2021
Merged
10 tasks
@Mathnerd314
Copy link
Contributor

ok ^

@jraygauthier
Copy link
Member

pythonnet can be updated from 2.4.0 -> 2.5.2. I should take a look at this soon.

@jraygauthier jraygauthier mentioned this pull request May 14, 2021
Merged
10 tasks
@dotlambda
Copy link
Member Author

@NixOS/nixos-release-managers Should we merge this before 21.05?

@SuperSandro2000 SuperSandro2000 merged commit f85bc84 into NixOS:master May 17, 2021
@dotlambda dotlambda deleted the mono6 branch May 18, 2021 07:34
@dotlambda
Copy link
Member Author

I guess we should make gtk-sharp-2_0 use mono5. Do all depending packages also have to use mono5 then?

No one addressed this.

@dotlambda
Copy link
Member Author

I guess we should make gtk-sharp-2_0 use mono5. Do all depending packages also have to use mono5 then?

No one addressed this.

Seems to have been fixed by #123521.

@mkg20001
Copy link
Member

@dotlambda There are some breakages in the packages, namely everything that uses Range since Gtk.Range and System.Range collides now. For bless I needed an update to fix it #123532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathnerd314 Mathnerd314 Mathnerd314 approved these changes

@jraygauthier jraygauthier jraygauthier approved these changes

@ericdallo ericdallo ericdallo approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@vrthra vrthra Awaiting requested review from vrthra

@stesie stesie Awaiting requested review from stesie

@delroth delroth Awaiting requested review from delroth

@msteen msteen Awaiting requested review from msteen

@vbgl vbgl Awaiting requested review from vbgl

@obadz obadz Awaiting requested review from obadz

@mkg20001 mkg20001 Awaiting requested review from mkg20001

@jonringer jonringer Awaiting requested review from jonringer

@kevincox kevincox Awaiting requested review from kevincox

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dotlambda @r-rmcgibbo @Mathnerd314 @jraygauthier @mkg20001 @ericdallo @SuperSandro2000